Feb. 3, 2023
8:16 p.m.
On Fri Feb 3 20:16:19 2023 +0000, Newbyte wrote: > > Also, not sure if a dark mode checkbox should be added or if dark mode > should be automatically set based on the loaded theme in Wine. Though, > for the latter there needs to be a property that returns the mode of the > theme. Name alone might not be sufficient. > I understand it's not entirely relevant to this MR, but have you > considered implementing support for the > `org.freedesktop.appearance.color-scheme` specification? It's used by > GNOME, KDE, elementary, Firefox/Thunderbird, and Telegram Desktop so > far. Probably others I didn't mention as well. > Relevant links: > - GNOME blog post: https://blogs.gnome.org/alexm/2021/10/04/dark-style-preference/ > - Spec: https://github.com/flatpak/xdg-desktop-portal/blob/d7a304a00697d7d608821253cd013f3b97ac0fb6/data/org.freedesktop.impl.portal.Settings.xml#L33-L45 > - KDE initial implementation: https://invent.kde.org/plasma/xdg-desktop-portal-kde/-/merge_requests/49 > - KDE proper implementation: https://invent.kde.org/plasma/xdg-desktop-portal-kde/-/merge_requests/52 I would like such an implementation as well, but that would require finding a way to move dbus out of mountmgr, and once this is done, it would allow for many other cool features in wine (bluetooth potentially, I have a proof of concept) along with this MR -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2103#note_22974