Re: [PATCH 0/5] MR6954: windowscodecs/tests: Use string literals in the metadata tests.

[Esme Povirk (＠madewokherd)]

Esme Povirk (@madewokherd) commented about dlls/windowscodecs/tests/metadata.c:
> len = 0xdeadbeef;
>          hr = WICMapGuidToShortName(&GUID_MetadataFormatIMD, 256, name, &len);
>          ok(hr == S_OK, "WICMapGuidToShortName error %#lx\n", hr);
> -        ok(!lstrcmpW(name, imgdescW), "wrong short name %s\n", wine_dbgstr_w(name));
> +        ok(!lstrcmpW(name, L"imgdesc"), "wrong short name %s\n", wine_dbgstr_w(name));
>
> format = GUID_NULL;
> -        hr = WICMapShortNameToGuid(imgdescW, &format);
> +        hr = WICMapShortNameToGuid(name, &format);

Why replace this with a variable instead of a constant?

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/6954#note_89715