April 13, 2023
10:13 a.m.
On Wed Apr 12 17:40:14 2023 +0000, Nikolay Sivov wrote: > Ok, I changed that. I am not completely sure I agree with error reporting in v5. IMHO: * on `unroll(X)` we should `hlsl_fixme()`, because ignoring the attribute might change the semantics significantly. Notice that `hlsl_fixme()` also sets `ctx->result`, so it essentially acts as `hlsl_error()`, but specifically marks that the error is on us, not on the caller. * on `unroll` it is sensible to `FIXME()`, because hopefully that shouldn't change the semantics too much. * on other attributes, we should `hlsl_fixme()`, because (AFAIU) there is at least an attribute that could change the semantics if ignored (e.g., `allow_uav_condition`). We could `hlsl_warning()` for the attributes we already consider relatively safe to ignore. However, I don't want to enter a review fight, so if Matteo or Zeb have different views I yield. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/150#note_29894