Sept. 5, 2023
12:53 p.m.
I think this is generally fine. Could you use lower-case hexadecimal for the following constants though?: - D3D12_HS_FORK_PHASE_INSTANCE_COUNT_UPPER_BOUND - D3D12_HS_JOIN_PHASE_INSTANCE_COUNT_UPPER_BOUND - D3D12_PS_FRONTFACING_DEFAULT_VALUE - D3D12_PS_FRONTFACING_TRUE_VALUE -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/327#note_44306