On Wed Mar 11 09:50:11 2026 +0000, Hans Leidekker wrote:
This needs some tests to cover the changes you make. You could expand the existing tests by adding data for the sections you add in this patch. Also note that this patch causes failures in the existing tests that should be addressed. and to extend Hans' comments:
* it looks very unlikely that digest is computed given a list of sections ordered by name; PE image format doesn't imply anything on the name of the sections ; it's a convention adopted by the toolchain you're using * so it's very likely that's the order you've implemented is the default order generated by toolchain you've used * expanding the tests by changing the order of sections shall demonstrate this * and also follow coding style (eg no c++ comments) side note: * current implementation blinding assumes image has same bitness as the DLL, which is wrong (IIRC native always supports 32 and 64bit images) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10295#note_131800