Oct. 10, 2022
5:13 a.m.
On Mon Oct 10 00:33:29 2022 +0000, **** wrote: > Zebediah Figura replied on the mailing list: > ``` > On 10/7/22 04:57, eric pouech (@epo) wrote: > > This serie could be a starting point for enabling long type > compilation in wined3d. > Maybe, although I think it may make sense to avoid tying wined3d to a > certain compiler target where possible, given its frequency of use as a > porting tool. Along the same lines, it's not unlikely that we'll move > parts of it to vkd3d, and I'm not sure that we're going to end up using > LLP64 there. > ``` Does it mean you'd rather wait for that migration to happen before considering migating to long types, or you'd favor long type migration by reducing at max the trace/printf changes (so that it doesn't change twice when considering the two migrations). If the second case, note that: - it means changing types so that they are the same in lp64 and llp64 (mainly no longer using dword & long, but int:s), example: moving all flags variable / parameters from DWORD to unsigned - but some plzces will could still require trace changes (eg NSTATUS or GetLastError where I think it s better to keep the windows type for clarity) - it's not very clear what would be preferred between using unsigned vs. uint32_t vs UINT. Current code uses the three forms but couldn't find out a pattern on when to use which. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1014#note_10112