[PATCH 0/1] MR1467: urlmon: Remove unused function heap_strdupWtoA.

[Alex Henrie (＠alexhenrie)]

This function was introduced in commit
59055c4d45c674c2a9dc2efcb8d0a973f870f3ac but never used.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/1467

[PATCH 1/1] urlmon: Remove unused function heap_strdupWtoA.

[Alex Henrie]

From: Alex Henrie <alexhenrie24(a)gmail.com>

This function was introduced in commit
59055c4d45c674c2a9dc2efcb8d0a973f870f3ac but never used.
---
 dlls/urlmon/urlmon_main.h | 14 --------------
 1 file changed, 14 deletions(-)

diff --git a/dlls/urlmon/urlmon_main.h b/dlls/urlmon/urlmon_main.h
index 691c63e3b42..6687fbd0516 100644
--- a/dlls/urlmon/urlmon_main.h
+++ b/dlls/urlmon/urlmon_main.h
@@ -281,18 +281,4 @@ static inline LPWSTR heap_strdupAtoW(const char *str)
     return ret;
 }
 
-static inline char *heap_strdupWtoA(const WCHAR *str)
-{
-    char *ret = NULL;
-
-    if(str) {
-        size_t size = WideCharToMultiByte(CP_ACP, 0, str, -1, NULL, 0, NULL, NULL);
-        ret = heap_alloc(size);
-        if(ret)
-            WideCharToMultiByte(CP_ACP, 0, str, -1, ret, size, NULL, NULL);
-    }
-
-    return ret;
-}
-
 #endif /* __WINE_URLMON_MAIN_H */
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/1467

[PATCH 1/1] urlmon: Remove unused function heap_strdupWtoA.

[Marvin]

Hi,

It looks like your patch introduced the new failures shown below.
Please investigate and fix them before resubmitting your patch.
If they are not new, fixing them anyway would help a lot. Otherwise
please ask for the known failures list to be updated.

The tests also ran into some preexisting test failures. If you know how
to fix them that would be helpful. See the TestBot job for the details:

The full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=126528

Your paranoid android.


=== debian11 (32 bit report) ===

d3d8:
stateblock: Timeout
visual: Timeout

d3d9:
d3d9ex: Timeout
device: Timeout
stateblock: Timeout
visual: Timeout

d3dcompiler_43:
asm: Timeout
blob: Timeout
hlsl_d3d11: Timeout
hlsl_d3d9: Timeout
reflection: Timeout

d3dcompiler_46:
asm: Timeout
blob: Timeout
hlsl_d3d11: Timeout
hlsl_d3d9: Timeout
reflection: Timeout

d3dcompiler_47:
asm: Timeout
blob: Timeout
hlsl_d3d11: Timeout
hlsl_d3d9: Timeout
reflection: Timeout

d3drm:
d3drm: Timeout
vector: Timeout

Report validation errors:
d3dx10: Timeout

=== debian11 (build log) ===

WineRunWineTest.pl:error: The task timed out

[PATCH 0/1] MR1467: urlmon: Remove unused function heap_strdupWtoA. - approved

[Jacek Caban (＠jacek)]

This merge request was approved by Jacek Caban.
-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/1467