Re: [PATCH v5 0/2] MR11376: wscript: Support UTF-16 LE and UTF-8 encoded script files.
On Tue Jul 14 09:41:33 2026 +0000, Lokesh Poovaragan wrote:
I checked both, I think it could be that the guest vm isn't fully brought up prior to the tests beginning, I'm mostly basing that on this line `Command '['virsh', 'qemu-agent-command', '--domain', 'glw1064', '{"execute": "guest-sync", "arguments": {"id": 226832}}']' returned non-zero exit status 1.` which is common between both the windows test boxes I am parallely also considering that it could be in Windows, when the test fails for some reason instead of printing to stderr it might be doing an error MessageBox popup which could also explain the deadlock I will try to run this on a Windows 10 vm to try to see if that popup is presented, I think apart from that maybe another run at the tests might work but better to rule out the popup prior to it is my planned approach I have confirmed, Windows's `wscript.exe` does not strip the BOM from .js files, so in windows CI, it sees it as `WScript.` this triggers the following popup in GUI, leading to the 120s timeout on CI
{width=498 height=272} And using `cscript.exe` it stderrs with `test_utf8bom.js(1, 1) Microsoft JScript runtime error: 'WScript' is undefined` So for this to work on CI, I have dropped the test for UTF-8 BOM (which I think is incorrect, I need a way to test on linux+wine but specifically exclude windows only for UTF-8 BOM, only for this test case) For the rest of the cases, UTF-16 LE and UTF-16 LE + BOM it works correctly and passes on windows + linux boxes -- https://gitlab.winehq.org/wine/wine/-/merge_requests/11376#note_145617
participants (1)
-
Lokesh Poovaragan (＠lokeshpoovaragan)