[PATCH 0/3] MR4498: winex11.drv, winemac.drv, wineandroid.drv: Set PFD_SUPPORT_COMPOSITION for hardware-accelerated pixel formats.

[Torge Matthies (＠tmatthies)]

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53500

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/4498

[PATCH 1/3] winex11.drv: Set PFD_SUPPORT_COMPOSITION for hardware-accelerated pixel formats.

[Torge Matthies]

From: Torge Matthies <tmatthies(a)codeweavers.com>

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53500
---
 dlls/winex11.drv/opengl.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/dlls/winex11.drv/opengl.c b/dlls/winex11.drv/opengl.c
index c9000648848..bb8f13f78b9 100644
--- a/dlls/winex11.drv/opengl.c
+++ b/dlls/winex11.drv/opengl.c
@@ -1589,6 +1589,9 @@ static int describe_pixel_format( int iPixelFormat, PIXELFORMATDESCRIPTOR *ppfd,
    * We only set PFD_GENERIC_FORMAT on bitmap formats (see get_formats) as that's what ATI and Nvidia Windows drivers do  */
   ppfd->dwFlags |= fmt->dwFlags & (PFD_GENERIC_FORMAT | PFD_GENERIC_ACCELERATED);
 
+  if (!(ppfd->dwFlags & PFD_GENERIC_FORMAT))
+    ppfd->dwFlags |= PFD_SUPPORT_COMPOSITION;
+
   pglXGetFBConfigAttrib(gdi_display, fmt->fbconfig, GLX_DOUBLEBUFFER, &value);
   if (value) {
       ppfd->dwFlags |= PFD_DOUBLEBUFFER;
-- 
GitLab


https://gitlab.winehq.org/wine/wine/-/merge_requests/4498

[PATCH 2/3] winemac.drv: Set PFD_SUPPORT_COMPOSITION for hardware-accelerated pixel formats.

[Torge Matthies]

From: Torge Matthies <tmatthies(a)codeweavers.com>

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53500
---
 dlls/winemac.drv/opengl.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/dlls/winemac.drv/opengl.c b/dlls/winemac.drv/opengl.c
index 55e5704724b..f78454ed149 100644
--- a/dlls/winemac.drv/opengl.c
+++ b/dlls/winemac.drv/opengl.c
@@ -4326,6 +4326,7 @@ static int macdrv_wglDescribePixelFormat(HDC hdc, int fmt, UINT size, PIXELFORMA
     descr->dwFlags          = PFD_SUPPORT_OPENGL;
     if (pf->window)         descr->dwFlags |= PFD_DRAW_TO_WINDOW;
     if (!pf->accelerated)   descr->dwFlags |= PFD_GENERIC_FORMAT;
+    else                    descr->dwFlags |= PFD_SUPPORT_COMPOSITION;
     if (pf->double_buffer)  descr->dwFlags |= PFD_DOUBLEBUFFER;
     if (pf->stereo)         descr->dwFlags |= PFD_STEREO;
     if (pf->backing_store)  descr->dwFlags |= PFD_SWAP_COPY;
-- 
GitLab


https://gitlab.winehq.org/wine/wine/-/merge_requests/4498

[PATCH 3/3] wineandroid.drv: Set PFD_SUPPORT_COMPOSITION for hardware-accelerated pixel formats.

[Torge Matthies]

From: Torge Matthies <tmatthies(a)codeweavers.com>

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53500
---
 dlls/wineandroid.drv/opengl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/wineandroid.drv/opengl.c b/dlls/wineandroid.drv/opengl.c
index 5146fdf4df9..99d2e3cebe1 100644
--- a/dlls/wineandroid.drv/opengl.c
+++ b/dlls/wineandroid.drv/opengl.c
@@ -466,7 +466,7 @@ static int android_wglDescribePixelFormat( HDC hdc, int fmt, UINT size, PIXELFOR
     memset( pfd, 0, sizeof(*pfd) );
     pfd->nSize = sizeof(*pfd);
     pfd->nVersion = 1;
-    pfd->dwFlags = PFD_SUPPORT_OPENGL | PFD_DRAW_TO_WINDOW | PFD_DOUBLEBUFFER;
+    pfd->dwFlags = PFD_SUPPORT_OPENGL | PFD_DRAW_TO_WINDOW | PFD_DOUBLEBUFFER | PFD_SUPPORT_COMPOSITION;
     pfd->iPixelType = PFD_TYPE_RGBA;
     pfd->iLayerType = PFD_MAIN_PLANE;
 
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/4498

[Torge Matthies (＠tmatthies)]

This bug also affects osu!, I don't know how to add it to the affected applications on the bug.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/4498#note_53790