Re: [PATCH v2 0/1] MR10352: cabinet: Add stubs for compressor/decompressor
March 24, 2026
9:13 a.m.
Nikolay Sivov (@nsivov) commented about dlls/cabinet/fci.c:
+ PVOID buff, + SIZE_T buffSize, + PSIZE_T compDataSize) +{ + FIXME("stub\n"); + + *compDataSize = dataSize; + + if( buffSize < dataSize ) + { + SetLastError( ERROR_INSUFFICIENT_BUFFER ); + return FALSE; + } + memcpy(buff, data, dataSize); + return TRUE; +} If it's not important to get application running, it's better to keep stub to a minimum. For instance here, we don't know if this is correct, without tests.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/10352#note_133509
2
Age (days ago)
2
Last active (days ago)
0 comments
1 participants
participants (1)
-
Nikolay Sivov (@nsivov)