[PATCH 0/2] MR10539: odbc32: Map SQLColAttributes(SQL_COLUMN_UNSIGNED) to SQLColAttribute().

[Nikolay Sivov (＠nsivov)]

Signed-off-by: Nikolay Sivov <[e-mail]>

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/10539

[PATCH 1/2] odbc32: Map SQLColAttributes(SQL_COLUMN_UNSIGNED) to SQLColAttribute().

[Nikolay Sivov]

From: Nikolay Sivov <[e-mail]>

Signed-off-by: Nikolay Sivov <[e-mail]>
---
 dlls/odbc32/proxyodbc.c | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/dlls/odbc32/proxyodbc.c b/dlls/odbc32/proxyodbc.c
index dbe080f424f..066e9c14064 100644
--- a/dlls/odbc32/proxyodbc.c
+++ b/dlls/odbc32/proxyodbc.c
@@ -4821,6 +4821,22 @@ static SQLRETURN col_attributes_win32_a( struct statement *stmt, SQLUSMALLINT co
             free( strW );
         }
     }
+
+    if (stmt->hdr.win32_funcs->SQLColAttribute)
+        FIXME("Use SQLColAttribute\n");
+
+    if (stmt->hdr.win32_funcs->SQLColAttributeW)
+    {
+        switch (field_id)
+        {
+            case SQL_COLUMN_UNSIGNED:
+                return stmt->hdr.win32_funcs->SQLColAttributeW( stmt->hdr.win32_handle, col, field_id, char_attrs, buflen,
+                        retlen, num_attrs );
+            default:
+                FIXME("Unsupported for field %d.\n", field_id);
+        }
+    }
+
     return ret;
 }
 
-- 
GitLab


https://gitlab.winehq.org/wine/wine/-/merge_requests/10539

[PATCH 2/2] include: Fix SQLDriverConnectW() prototype.

[Nikolay Sivov]

From: Nikolay Sivov <[e-mail]>

Signed-off-by: Nikolay Sivov <[e-mail]>
---
 include/sqlucode.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/sqlucode.h b/include/sqlucode.h
index 1a17f3af63f..e36b9269e8e 100644
--- a/include/sqlucode.h
+++ b/include/sqlucode.h
@@ -60,7 +60,7 @@ SQLRETURN WINAPI SQLDataSourcesW(SQLHENV,SQLUSMALLINT,SQLWCHAR*,SQLSMALLINT,SQLS
 SQLRETURN WINAPI SQLDescribeColW(SQLHSTMT,SQLUSMALLINT,SQLWCHAR*,SQLSMALLINT,SQLSMALLINT*,SQLSMALLINT*,SQLULEN*,
                                  SQLSMALLINT*,SQLSMALLINT*);
 
-SQLRETURN WINAPI SQLDriverConnectW(SQLHDBC,SQLHWND,WCHAR*,SQLSMALLINT,WCHAR*,SQLSMALLINT,SQLSMALLINT*,SQLUSMALLINT);
+SQLRETURN WINAPI SQLDriverConnectW(SQLHDBC,SQLHWND,SQLWCHAR*,SQLSMALLINT,SQLWCHAR*,SQLSMALLINT,SQLSMALLINT*,SQLUSMALLINT);
 
 SQLRETURN WINAPI SQLDriversW(SQLHENV,SQLUSMALLINT,SQLWCHAR*,SQLSMALLINT,SQLSMALLINT*,SQLWCHAR*,SQLSMALLINT,
                              SQLSMALLINT*);
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/10539

[Nikolay Sivov (＠nsivov)]

To give it some context, this failure showed up with "SQL Server ODBC v17" driver which is ODBC v3, used with ODBC v2 application.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/10539#note_134840

[Hans Leidekker (＠hans)]

Looks good. SQLColAttributes() was deprecated in v2 and replaced with SQLColAttribute(). Generally we want support to old APIs on newer driver versions. Native also supports it the other way around (with limitations of course) which I think we should only do if we find a real-world configuration that needs it.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/10539#note_134844

[PATCH 0/2] MR10539: odbc32: Map SQLColAttributes(SQL_COLUMN_UNSIGNED) to SQLColAttribute(). - approved

[Hans Leidekker (＠hans)]

This merge request was approved by Hans Leidekker.
-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/10539

[Nikolay Sivov (＠nsivov)]

On Fri Apr  3 08:00:01 2026 +0000, Hans Leidekker wrote:
> Looks good. SQLColAttributes() was deprecated in v2 and replaced with
> SQLColAttribute(). Generally we want support to old APIs on newer driver
> versions. Native also supports it the other way around (with limitations
> of course) which I think we should only do if we find a real-world
> configuration that needs it.
> Yes, it should be case by case, so that it's tested at least in some way.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/10539#note_134908

[PATCH 0/2] MR10539: odbc32: Map SQLColAttributes(SQL_COLUMN_UNSIGNED) to SQLColAttribute(). - approved

[Piotr Caban (＠piotr)]

This merge request was approved by Piotr Caban.
-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/10539