Re: [PATCH v4 0/7] MR9131: iertutil: Move URI parser from urlmon.
March 30, 2026
8:03 p.m.
Jacek Caban (@jacek) commented about dlls/urlmon/uri.c:
TRACE("(%p)->(IID_IUriObj %p)\n", This, ppv); *ppv = This; return S_OK; + }else if(IsEqualGUID(&IID_IUriCanonUri, riid)) { + TRACE("(%p)->(IID_IUriCanonUri %p)\n", This, ppv); + *ppv = This->canon_uri; + return S_OK;
Please don't abuse `QueryInterface` like that. We may add a proper private interface with a getter or somehow export `get_canonicalized_uri` from iertutil. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/9131#note_134387
24
Age (days ago)
24
Last active (days ago)
0 comments
1 participants
participants (1)
-
Jacek Caban (@jacek)