Re: [PATCH v5 0/1] MR80: vkd3d-shader/hlsl: Support reflect() intrinsic.
Feb. 15, 2023
1:55 p.m.
On Wed Feb 15 13:55:41 2023 +0000, Nikolay Sivov wrote:
Hi, @giomasce. Is anything blocking this MR? I'd like to see more tests that `reflect()` really behaves like on native with different types combinations. For example, what happens if you call `reflect()` on a `float` and a `float2`? Or on a `float2` and a `float3`? From my tests, it seems that the current implementation is correct, but it would be nice to have this shown by tests, so that we don't regress it in the future. It should be quite a quick thing to do.
-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/80#note_24372
1136
Age (days ago)
1136
Last active (days ago)
0 comments
1 participants
participants (1)
-
Giovanni Mascellani (ļ¼ giomasce)