Re: [PATCH v2 0/1] MR10948: include: Update CERT_KEY_CONTEXT.
Trent Waddington (@trent.waddington) commented about dlls/crypt32/cert.c:
break; } keyContext.cbSize = sizeof(keyContext); - keyContext.hCryptProv = *(const HCRYPTPROV *)pvData; + keyContext.hNCryptKey = *(const NCRYPT_KEY_HANDLE *)pvData;
We were recently investigating this code when running `dotnet restore` and it would appear that crypt32 on Windows doesn't do this dereference. The value of pvData is stored into the parameter and will be retrieved later. Doing the dereference here results in the contents of the handle being stored and causes a later crash. i.e., the documentation says what you're doing here is right, but the implementation doesn't match that. It would be great if you could confirm, as we have questioned our sanity investigating this. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10948#note_140742
participants (1)
-
Trent Waddington (@trent.waddington)