[PATCH 0/1] MR10401: setupapi: Fix wrong buffer size in SetupDiGetClassDescriptionExA.

[Yuxuan Shui (＠yshui)]

lenW is in number of characters, not number of bytes.

Found by ASan.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/10401

[PATCH 1/1] setupapi: Fix wrong buffer size in SetupDiGetClassDescriptionExA.

[Yuxuan Shui]

From: Yuxuan Shui <[e-mail]>

lenW is in number of characters, not number of bytes.

Found by ASan.
---
 dlls/setupapi/devinst.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/setupapi/devinst.c b/dlls/setupapi/devinst.c
index de628d81bd2..668aa6d2864 100644
--- a/dlls/setupapi/devinst.c
+++ b/dlls/setupapi/devinst.c
@@ -1893,7 +1893,7 @@ BOOL WINAPI SetupDiGetClassDescriptionExA(const GUID *class, char *buffer, DWORD
             debugstr_guid(class), buffer, buffer_len, required_len, debugstr_a(machine_nameA), reserved);
 
     ret = SetupDiGetClassDescriptionExW(class, NULL, 0, &lenW, machine_nameW, reserved);
-    bufferW = lenW ? malloc(lenW) : NULL;
+    bufferW = lenW ? malloc(lenW * sizeof(WCHAR)) : NULL;
     if (bufferW && (ret = SetupDiGetClassDescriptionExW(class, bufferW, lenW, &lenW, machine_nameW, reserved)) && lenW)
         lenA = WideCharToMultiByte(CP_ACP, 0, bufferW, lenW, buffer, buffer_len, NULL, NULL);
     free(bufferW);
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/10401

[Yuxuan Shui (＠yshui)]

@zfigura hello. this is simple change, can you have a look?

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/10401#note_134677

[PATCH 0/1] MR10401: setupapi: Fix wrong buffer size in SetupDiGetClassDescriptionExA. - approved

[Elizabeth Figura (＠zfigura)]

This merge request was approved by Elizabeth Figura.
-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/10401