Re: [PATCH v7 0/3] MR600: wine{alsa,pulse}: Merge unixlib.h, move it into mmdevapi
Aug. 11, 2022
12:51 a.m.
On Wed Aug 10 19:57:25 2022 +0000, Davide Beatrici wrote: > > If you're adding parameters to existing unixcalls you should at least > zero-init them in the caller. > I planned to do that when achieving a single `mmdevdrv.c`, but to avoid > confusion I'll do it in this MR instead. > > Also, this MR is getting rather long. I'd suggest just pushing the > first five or so commits, saving the rest for later MRs. > We would end up with a single "topic" split between different MRs, though. > I think it would make more sense to divide the commits like this: > - 1-3 in this MR. > - 4-12 in a 2nd MR. > - 13 in a 3rd MR. Maybe I should merge `wineoss` and `winecoreaudio`'s `unixlib.h` here as well. That way we can then create a merge request for each driver, strictly focused on making it work with `mmdevdrv`'s header. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/600#note_6080
1323
Age (days ago)
1323
Last active (days ago)
0 comments
1 participants
participants (1)
-
Davide Beatrici (@davidebeatrici)