Re: [PATCH v2 0/4] MR10967: Prefer builtin for d3d helper libraries.
I realize that there might be other considerations why preferring builtin might still be making sense, but it seems to me the argument for forcing builtin for the purpose of easier getting aware of builtin bugs is a bit counter-intuitive, it reads to me like adding a hack, and, curiously, with the purpose to break things intentionally.
This was never my primary intention, no. I do enjoy working on the HLSL compiler, but my comment above was not meant to be taken as an actual rationale for this patch series. Rather, see !10943 and !10955. Essentially, I found it odd that prefer-native was present in some places where native either surely couldn't work or wasn't redistributable, and wanted to remove them. In response Alexandre expressed a preference to get rid of prefer-native entirely. I understand this to indeed mean a preference for all DLLs to be builtin even when the Microsoft DLL is redistributable, and I suppose this is a philosophical difference (whether Wine's goal is simply to run programs, or whether it is to reimplement win32). I don't personally have much of an opinion on that question, but I saw no reason not to do what the maintainer requested in regards to a simple task. It was my intention to keep sending patches and eventually remove most if not all prefer-native annotations, although for various reasons I haven't done so for a couple weeks. On the other hand, seeing as there's some pushback, I'll hold off for now, at least for the DLLs that frequently get redistributables... -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10967#note_144499
participants (1)
-
Elizabeth Figura (@zfigura)