[PATCH v2 0/1] MR10452: comctl32/tests: Print WM_NOTIFY codes on failure

[Piotr Pawłowski (＠DEATH)]

Makes debugging of WM_NOTIFY message sequence errors much easier.

--
  v2: comctl32/tests: Print WM_NOTIFY codes of logged/expected events on failure
 
https://gitlab.winehq.org/wine/wine/-/merge_requests/10452

[PATCH v2 1/1] comctl32/tests: Print WM_NOTIFY codes of logged/expected events on failure

[Piotr Pawłowski]

From: Piotr Pawłowski <[e-mail]>

---
 dlls/comctl32/tests/msg.h | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/dlls/comctl32/tests/msg.h b/dlls/comctl32/tests/msg.h
index 76bf5450b2f..8eb319f4889 100644
--- a/dlls/comctl32/tests/msg.h
+++ b/dlls/comctl32/tests/msg.h
@@ -115,8 +115,9 @@ static void dump_sequence( struct msg_sequence **seq, int sequence_index,
     trace_(file, line)("Failed sequence %s:\n", context );
     while (expected->message && actual->message)
     {
-        trace_(file, line)( "  %u: expected: %04x - actual: %04x wp %08Ix lp %08Ix\n",
-                            count, expected->message, actual->message, actual->wParam, actual->lParam );
+        trace_(file, line)( "  %u: expected: %04x id %i - actual: %04x wp %08Ix lp %08Ix id %i\n",
+                            count, expected->message, (int)expected->id, actual->message, actual->wParam, actual->lParam, (int)actual->id );
+
 
 	if (expected->message == actual->message)
 	{
@@ -157,8 +158,8 @@ static void dump_sequence( struct msg_sequence **seq, int sequence_index,
 
     while (actual->message)
     {
-        trace_(file, line)( "  %u: expected: nothing - actual: %04x wp %08Ix lp %08Ix\n",
-                            count, actual->message, actual->wParam, actual->lParam );
+        trace_(file, line)( "  %u: expected: nothing - actual: %04x wp %08Ix lp %08Ix id %i\n",
+                            count, actual->message, actual->wParam, actual->lParam, (int)actual->id );
         actual++;
         count++;
     }
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/10452

[Nikolay Sivov (＠nsivov)]

This field is only meaningful when "flags & id".

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/10452#note_134004

[Piotr Pawłowski (＠DEATH)]

On Fri Mar 27 13:00:02 2026 +0000, Nikolay Sivov wrote:
> This field is only meaningful when "flags & id".
> For expected messages yes it is.

For actual logged messages, look at parent_wnd_proc() in about every test logging WM_NOTIFY. The flag is not being set when setting id field.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/10452#note_134038

[Nikolay Sivov (＠nsivov)]

On Fri Mar 27 13:00:02 2026 +0000, Piotr Pawłowski wrote:
> For expected messages yes it is.
> For actual logged messages, look at parent_wnd_proc() in about every
> test logging WM_NOTIFY. The flag is not being set when setting id field.
> It's not always used for WM_NOTIFY codes. I don't see a problem in printing it in principle, but commit message needs to be more neutral, since it's not about WM_NOTIFY necessarily.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/10452#note_134043