Re: [PATCH v2 0/2] MR10271: Fixed thread safety issues with NtUserRegistClassExWOW and NtUserUnregisterClass.
March 23, 2026
1:43 p.m.
Rémi Bernon (@rbernon) commented about dlls/win32u/class.c:
SERVER_END_REQ; if (!ret) { + NtUserDestroyCursor( sm_icon, 0 ); free( class ); + user_unlock(); return 0; }
I'd move `NtUserDestroyCursor` outside of the user lock, as creation happens outside of it as well, and introduce a `goto failed;` here to share the error path with the other error below: ``` failed: user_unlock(); NtUserDestroyCursor( sm_icon, 0 ); free( class ); return 0; ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10271#note_133370
3
Age (days ago)
3
Last active (days ago)
0 comments
1 participants
participants (1)
-
Rémi Bernon