Re: [PATCH v3 0/6] MR2435: Fix activation context switching from SwitchToFiber().
April 18, 2023
12:28 p.m.
I must be missing something, when can dest == src?
If `ActivationContextStackPointer` already equals `dest` (fiber data or TEB). I think it's not possible currently, unless the user tinkers with undocumented fields (which we don't need to support right now).
Aren't we always moving from the fiber data to the TEB in ConvertFiberToThread()?
Or in the other direction in case of `ConvertThreadToFiber()`, but yes, `dest != src` in that case too. I'll remove the check, since I realized it would not be necessary even if `dest == src` was indeed true. Thank you for your review. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2435#note_30358
1074
Age (days ago)
1074
Last active (days ago)
0 comments
1 participants
participants (1)
-
Jinoh Kang (@iamahuman)