Re: [PATCH v7 0/2] MR10291: Fix GetModuleFileName string termination

[Akihiro Sagawa (＠sgwaki)]

Akihiro Sagawa (@sgwaki) commented about dlls/kernel32/tests/loader.c:
> +
> +    {
> +        IMAGE_NT_HEADERS nt_header = nt_header_template;
> +        char dll_name_a[MAX_PATH];
> +        HMODULE mod;
> +
> +        nt_header.FileHeader.NumberOfSections = 1;
> +        nt_header.FileHeader.SizeOfOptionalHeader = sizeof(IMAGE_OPTIONAL_HEADER);
> +
> +        nt_header.OptionalHeader.SectionAlignment = page_size;
> +        nt_header.OptionalHeader.DllCharacteristics = IMAGE_DLLCHARACTERISTICS_NX_COMPAT | IMAGE_DLLCHARACTERISTICS_DYNAMIC_BASE;
> +        nt_header.OptionalHeader.FileAlignment = page_size;
> +        nt_header.OptionalHeader.SizeOfHeaders = sizeof(dos_header) + sizeof(nt_header) + sizeof(IMAGE_SECTION_HEADER);
> +        nt_header.OptionalHeader.SizeOfImage = sizeof(dos_header) + sizeof(nt_header) + sizeof(IMAGE_SECTION_HEADER) + page_size;
> +
> +        create_test_dll( &dos_header, sizeof(dos_header), &nt_header, dll_name_a );
> I don't think it's necessary to create a new DLL file. How about using an existing one, such as shell32.dll?

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/10291#note_132022