Re: [PATCH v7 0/2] MR10291: Fix GetModuleFileName string termination
March 12, 2026
2:38 p.m.
Akihiro Sagawa (@sgwaki) commented about dlls/kernelbase/loader.c:
SetLastError( RtlNtStatusToDosError( status )); done: TRACE( "%s\n", debugstr_wn(filename, len) ); + if (!status || status == STATUS_BUFFER_TOO_SMALL) + { + if (len < size) + filename[len] = 0; + else if (size > 0)
Consider adding a test for the false case. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10291#note_132027
15
Age (days ago)
15
Last active (days ago)
0 comments
1 participants
participants (1)
-
Akihiro Sagawa (@sgwaki)