Re: [PATCH v5 0/1] MR5691: timeout: Add new program.

[eric pouech (＠epo)]

eric pouech (@epo) commented about programs/timeout/timeout_main.c:
> +
> +#include <stdio.h>
> +#include <stdlib.h>
> +#include <string.h>
> +#include <conio.h>
> +#include <math.h>
> +
> +#include <windows.h>
> +
> +#include "resources.h"
> +
> +#include <wine/debug.h>
> +
> +WINE_DEFAULT_DEBUG_CHANNEL(timeout);
> +
> +static char* get_string(int which)
a couple of remarks here (about the helpers for printing):
- returning ASCII strings could lose some bits in conversion, so you'd be safer keeping unicode string
- also usage of (w)printf can lack flexibility in translations (it assumes all parameters have the same order whatever the translation). FormatMessage brings more flexibility as you can change the order of parameters in output.
- and likely RPRINTF_VA could be rewritten as a function and not a macro

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/5691#note_71012