Re: [PATCH v5 0/2] MR10735: dsound: Create independent devices for each DirectSoundCreate call.

April 28, 2026


      On Tue Apr 28 10:49:16 2026 +0000, Jon Koops wrote:
...
Also note that DirectSoundDevice-\>ref can now be cleaned up, as there
isn't any actual ref counting happening anymore, it is only ever set to
1, and then set to 0, which immediately destroys the device right after.
However, I have opted to keep that cleanup out of this PR to keep it
simple to review. I'll see if that can be handled in a follow up PR.
Thumb up on that.
I'll also point out that `DirectSoundDevice` is not a public API but just an internal object, so this refcounting (or lack thereof) is not going to affect anything visible outside.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/10735#note_137959

Matteo Bruni (＠Mystral)

tags

participants (1)