Re: [PATCH v42 0/2] MR10291: Fix GetModuleFileName string termination
On Wed Mar 25 23:26:00 2026 +0000, eric pouech wrote:
what's strange at first glance is that first commit (the one which add tests) doesn't show any todo_wine marks we expect every commit to run the regression suite without errors, so that we can safely do binary search in the git tree for CI failures so either: * you didn't run the non regression tests on the first commit, and forgot to mark the failing tests as todo_wine * or current kernel32/kernelbase code behaves correctly, and this MR is pretty useless Ahh, I am learning!
First commit now has todo_wine marks and I confirmed these appear as "Test marked todo" in the test output. Second commit fixes the code and removes the todo_wine marks. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10291#note_133807
participants (1)
-
Trent Waddington (@trent.waddington)