Re: [PATCH v3 0/4] MR10751: winscard: Implement SCardGetCardTypeProviderName and SCardListCards (smartcard database)

[Hans Leidekker (＠hans)]

Hans Leidekker (@hans) commented about dlls/winscard/tests/winscard.c:
> +    ret = RegOpenKeyExA(hkey, name, 0, KEY_READ|KEY_WRITE, &key);
> +    if (ret == ERROR_SUCCESS) {
> +        ret = RegDeleteTreeA(key, NULL);
> +        if (ret != ERROR_SUCCESS) {
> +            return ret;
> +        }
> +    }
> +    ret = RegCreateKeyExA(hkey, name, 0, NULL, 0, KEY_READ|KEY_WRITE, NULL, open_key, NULL);
> +    return ret;
> +}
> +
> +const char* SUBKEY_SMARTCARDS_DATABASE = "SOFTWARE\\Microsoft\\Cryptography\\Calais\\SmartCards";
> +const char *CARD_NAME_1 = "PKI-test-1";
> +const char *CARD_NAME_2 = "PKI-test-2";
> +const WCHAR *CARD_NAME_1L = L"PKI-test-1";
> +const WCHAR *CARD_NAME_2L = L"PKI-test-2";
> Please use lower-case for the variables. The convention is to use a W suffix for wide character strings.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/10751#note_137723