[PATCH 0/1] MR10272: iphlpapi: Swap the order of address families in call_families to process IPv4...

[Zhao Yi (＠Zhaoyi)]

A Ruby application obtains network adapter IP information by calling the **Win32_NetworkAdapterConfiguration** class. However, the order of IPv4 and IPv6 addresses retrieved on Windows differs from that retrieved when running on Wine, which causes Ruby applications running on Wine to malfunction.
A test demo was written that calls the **Win32_NetworkAdapterConfiguration** class to obtain network adapter information. It was run on Windows and on Wine respectively, and the results are as follows.
The results of running on Windows：
![test-on-windows](/uploads/fa48781357a2b86e10fbb5a616ca25ad/test-on-windows.png){width=357 height=153}
The results of running on Wine：
![test-on-wine](/uploads/79e0bffb5a41b529c5b3593c449121f4/test-on-wine.png){width=363 height=66}

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/10272

[PATCH 1/1] iphlpapi: Swap the order of address families in call_families to process IPv4 first when family is AF_UNSPEC.

[Zhao Yi]

From: Zhao Yi <[e-mail]>

Signed-off-by: Zhao Yi <[e-mail]>
---
 dlls/iphlpapi/iphlpapi_main.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/dlls/iphlpapi/iphlpapi_main.c b/dlls/iphlpapi/iphlpapi_main.c
index fe2de41c4a3..c850de9d900 100644
--- a/dlls/iphlpapi/iphlpapi_main.c
+++ b/dlls/iphlpapi/iphlpapi_main.c
@@ -1150,15 +1150,15 @@ static DWORD call_families( DWORD (*fn)( IP_ADAPTER_ADDRESSES *aa, ULONG family,
 {
     DWORD err;
 
-    if (family != AF_INET)
+    if (family != AF_INET6)
     {
-        err = fn( aa, AF_INET6, flags );
+        err = fn( aa, AF_INET, flags );
         if (err) return err;
     }
 
-    if (family != AF_INET6)
+    if (family != AF_INET)
     {
-        err = fn( aa, AF_INET, flags );
+        err = fn( aa, AF_INET6, flags );
         if (err) return err;
     }
     return err;
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/10272

[Nikolay Sivov (＠nsivov)]

This should probably be tested in both iphlpapi and wmi.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/10272#note_131567

[Paul Gofman (＠gofman)]

Also call_families affects various functions, if it is indeed iphlpapi output order is wrong in some maybe it needs explicit sorting.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/10272#note_131600