[PATCH 0/1] MR5277: mfreadwrite: Fix a memory leak (Coverity).

[Zhiyi Zhang (＠zhiyi)]

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/5277

[PATCH 1/1] mfreadwrite: Fix a memory leak (Coverity).

[Zhiyi Zhang]

From: Zhiyi Zhang <zzhang(a)codeweavers.com>

---
 dlls/mfreadwrite/reader.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/dlls/mfreadwrite/reader.c b/dlls/mfreadwrite/reader.c
index 5cd4641a0d4..5538739fe6b 100644
--- a/dlls/mfreadwrite/reader.c
+++ b/dlls/mfreadwrite/reader.c
@@ -1925,7 +1925,10 @@ static HRESULT source_reader_create_transform(struct source_reader *reader, BOOL
     if (SUCCEEDED(hr = MFTEnum(category, 0, &in_type, allow_processor ? NULL : &out_type, NULL, &classes, &count)))
     {
         if (!count)
+        {
+            free(entry);
             return MF_E_TOPO_CODEC_NOT_FOUND;
+        }
 
         for (i = 0; i < count; i++)
         {
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/5277

[PATCH 1/1] mfreadwrite: Fix a memory leak (Coverity).

[Marvin]

Hi,

It looks like your patch introduced the new failures shown below.
Please investigate and fix them before resubmitting your patch.
If they are not new, fixing them anyway would help a lot. Otherwise
please ask for the known failures list to be updated.

The tests also ran into some preexisting test failures. If you know how
to fix them that would be helpful. See the TestBot job for the details:

The full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=143946

Your paranoid android.


=== debian11 (32 bit report) ===

mfreadwrite:
Unhandled exception: assertion failed in 32-bit code (0xf7f62559).
mfplat: Timeout

Report validation errors:
mfreadwrite:mfplat prints too much data (51922 bytes)

=== debian11b (64 bit WoW report) ===

secur32:
schannel.c:538: Test failed: cert_cnt = 2

[PATCH 0/1] MR5277: mfreadwrite: Fix a memory leak (Coverity). - approved

[Nikolay Sivov (＠nsivov)]

This merge request was approved by Nikolay Sivov.
-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/5277