[PATCH 0/1] MR11716: shell32/tests: Mark systray test as flaky on Windows

[Andrea Faulds (＠hikari_no_yume)]

It seems to fail on the Windows 10 runners for every MR that touches
shell32 and thus triggers the test, but as far as I can tell there is
nothing wrong with the test itself, and it does run fine in my Win10 VM.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/11716

[PATCH 1/1] shell32/tests: Mark systray test as flaky on Windows

[Andrea Faulds]

From: Andrea Faulds <[e-mail]>

It seems to fail on the Windows 10 runners for every MR that touches
shell32 and thus triggers the test, but as far as I can tell there is
nothing wrong with the test itself, and it does run fine in my Win10 VM.
---
 dlls/shell32/tests/systray.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/dlls/shell32/tests/systray.c b/dlls/shell32/tests/systray.c
index 80621761240..92b79299655 100644
--- a/dlls/shell32/tests/systray.c
+++ b/dlls/shell32/tests/systray.c
@@ -33,6 +33,14 @@ static void test_cbsize(void)
     NOTIFYICONDATAA nidA;
     BOOL ret;
 
+    /* This test frequently fails with an "unknown error" on Windows in CI, but
+     * it does work fine when run standalone, and has no problems in WINE.
+     */
+    if (!running_under_wine())
+    {
+        flaky
+    }
+
     if (pShell_NotifyIconW)
     {
         NOTIFYICONDATAW nidW;
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/11716