[PATCH 0/1] MR6870: threadpoolwinrt: Fix potential NULL dereference in QueryInterface for IAsyncAction.

[Vibhav Pant (＠vibhavp)]

Fix a potential NULL dereference if `QueryInterface` gets called with an unsupported IID.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/6870

[PATCH 1/1] threadpoolwinrt: Fix potential NULL dereference in QueryInterface for IAsyncAction.

[Vibhav Pant]

From: Vibhav Pant <vibhavp(a)gmail.com>

---
 dlls/threadpoolwinrt/main.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/dlls/threadpoolwinrt/main.c b/dlls/threadpoolwinrt/main.c
index f58c381cbbc..fe637ad0ce0 100644
--- a/dlls/threadpoolwinrt/main.c
+++ b/dlls/threadpoolwinrt/main.c
@@ -91,6 +91,7 @@ static HRESULT STDMETHODCALLTYPE async_action_QueryInterface(IAsyncAction *iface
     {
         *out = NULL;
         WARN("Unsupported interface %s.\n", debugstr_guid(iid));
+        return E_NOINTERFACE;
     }
 
     IUnknown_AddRef((IUnknown *)*out);
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/6870

[PATCH 1/1] threadpoolwinrt: Fix potential NULL dereference in QueryInterface for IAsyncAction.

[Marvin]

Hi,

It looks like your patch introduced the new failures shown below.
Please investigate and fix them before resubmitting your patch.
If they are not new, fixing them anyway would help a lot. Otherwise
please ask for the known failures list to be updated.

The tests also ran into some preexisting test failures. If you know how
to fix them that would be helpful. See the TestBot job for the details:

The full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=149826

Your paranoid android.


=== debian11b (64 bit WoW report) ===

user32:
win.c:4070: Test failed: Expected active window 0000000004DF016E, got 0000000000000000.
win.c:4071: Test failed: Expected focus window 0000000004DF016E, got 0000000000000000.

[PATCH 0/1] MR6870: threadpoolwinrt: Fix potential NULL dereference in QueryInterface for IAsyncAction. - approved

[Nikolay Sivov (＠nsivov)]

This merge request was approved by Nikolay Sivov.
-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/6870