[PATCH 0/3] MR4433: Enable DualSense features for DualSense Edge controller

[Nell Hardcastle (＠nell)]

This adds the product ids for the DualSense Edge to enable feature parity with the existing DualSense suppport.

I've tested this with the DualSense Edge hardware and these Windows games installed from Steam:

* Returnal
* Death Stranding: Director's Cut
* Overwatch 2

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/4433

[PATCH 1/3] winebus.sys: Identify DualSense Edge as a DualSense controller

[Nell Hardcastle]

From: Nell Hardcastle <nell(a)dev-nell.com>

The DualSense Edge implements extra features (haptics and adaptive triggers)
in the same way as the DualSense.
---
 dlls/winebus.sys/unixlib.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/dlls/winebus.sys/unixlib.c b/dlls/winebus.sys/unixlib.c
index 74b4992f07b..82eab3717ca 100644
--- a/dlls/winebus.sys/unixlib.c
+++ b/dlls/winebus.sys/unixlib.c
@@ -72,7 +72,9 @@ BOOL is_dualshock4_gamepad(WORD vid, WORD pid)
 
 BOOL is_dualsense_gamepad(WORD vid, WORD pid)
 {
-    if (vid == 0x054c && pid == 0x0ce6) return TRUE;
+    if (vid != 0x054c) return FALSE;
+    if (pid == 0x0ce6) return TRUE; /* DualSense */
+    if (pid == 0x0df2) return TRUE; /* DualSense Edge */
     return FALSE;
 }
 
-- 
GitLab


https://gitlab.winehq.org/wine/wine/-/merge_requests/4433

[PATCH 2/3] mmdevapi: Override product strings for DualSense Edge

[Nell Hardcastle]

From: Nell Hardcastle <nell(a)dev-nell.com>

Enables audio device features for the DualSense Edge
---
 dlls/mmdevapi/devenum.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/dlls/mmdevapi/devenum.c b/dlls/mmdevapi/devenum.c
index 10037a7affe..246625286b8 100644
--- a/dlls/mmdevapi/devenum.c
+++ b/dlls/mmdevapi/devenum.c
@@ -294,6 +294,7 @@ static const struct product_name_overrides product_name_overrides[] =
 {
     /* Sony controllers */
     { .id = L"VID_054C&PID_0CE6", .product = L"Wireless Controller" },
+    { .id = L"VID_054C&PID_0DF2", .product = L"Wireless Controller" },
 };
 
 static const WCHAR *find_product_name_override(const WCHAR *device_id)
-- 
GitLab


https://gitlab.winehq.org/wine/wine/-/merge_requests/4433

[PATCH 3/3] hidclass.sys: Add DualSense Edge to device_strings

[Nell Hardcastle]

From: Nell Hardcastle <nell(a)dev-nell.com>

---
 dlls/hidclass.sys/device.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/dlls/hidclass.sys/device.c b/dlls/hidclass.sys/device.c
index d673a8c2e88..8fde1fe10a5 100644
--- a/dlls/hidclass.sys/device.c
+++ b/dlls/hidclass.sys/device.c
@@ -403,6 +403,7 @@ static const struct device_strings device_strings[] =
     { .id = L"VID_054C&PID_09CC", .product = L"Wireless Controller" },
     { .id = L"VID_054C&PID_0BA0", .product = L"Wireless Controller" },
     { .id = L"VID_054C&PID_0CE6", .product = L"Wireless Controller" },
+    { .id = L"VID_054C&PID_0DF2", .product = L"Wireless Controller" },
 };
 
 static const WCHAR *find_device_string( const WCHAR *device_id, ULONG index )
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/4433

[PATCH 3/3] hidclass.sys: Add DualSense Edge to device_strings

[Marvin]

Hi,

It looks like your patch introduced the new failures shown below.
Please investigate and fix them before resubmitting your patch.
If they are not new, fixing them anyway would help a lot. Otherwise
please ask for the known failures list to be updated.

The tests also ran into some preexisting test failures. If you know how
to fix them that would be helpful. See the TestBot job for the details:

The full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=140041

Your paranoid android.


=== debian11 (32 bit report) ===

mmdevapi:
capture.c:160: Test failed: GetNextPacketSize 480 vs. GetBuffer 0

[Rémi Bernon]

NP: Julliard will probably fix it for you but we add a trailing '.' at the end of the commits message titles.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/4433#note_52854

[PATCH 0/3] MR4433: Enable DualSense features for DualSense Edge controller - approved

[Rémi Bernon]

This merge request was approved by Rémi Bernon.
-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/4433