[PATCH v2 0/1] MR10953: Draft: Update default i386_CFLAGS
The immediate reason for this is !10716, but I suspect it might come in handy in other places as well. FWIW I've been building Wine with similar CFLAGS for many, many years. -- v2: configure: Add x86-64 CPU features to default i386_EXTRACFLAGS. https://gitlab.winehq.org/wine/wine/-/merge_requests/10953
From: Matteo Bruni <mbruni@codeweavers.com> The most restrictive of those is SSE2, which has been supported by x86 CPUs since the Intel Pentium 4 (2000) and the AMD Athlon 64 (2003). --- configure.ac | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/configure.ac b/configure.ac index 60262f26f68..edd41f6ebc8 100644 --- a/configure.ac +++ b/configure.ac @@ -629,6 +629,10 @@ This is an error since --enable-archs=$wine_arch was requested.])]) i386) WINE_TRY_PE_CFLAGS([-fno-omit-frame-pointer]) WINE_TRY_PE_CFLAGS([-mpreferred-stack-boundary=2]) WINE_TRY_PE_CFLAGS([-mlong-double-64]) + WINE_TRY_PE_CFLAGS([-mmmx]) + WINE_TRY_PE_CFLAGS([-msse]) + WINE_TRY_PE_CFLAGS([-msse2]) + WINE_TRY_PE_CFLAGS([-mfxsr]) WINE_TRY_PE_CFLAGS([-Wl,--disable-stdcall-fixup], [AS_VAR_APPEND([${wine_arch}_LDFLAGS],[" -Wl,--disable-stdcall-fixup"])]) ;; x86_64) WINE_TRY_PE_CFLAGS([-Wformat-overflow]) -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/10953
Alexandre Julliard (@julliard) commented about configure.ac:
i386) WINE_TRY_PE_CFLAGS([-fno-omit-frame-pointer]) WINE_TRY_PE_CFLAGS([-mpreferred-stack-boundary=2]) WINE_TRY_PE_CFLAGS([-mlong-double-64]) + WINE_TRY_PE_CFLAGS([-mmmx]) + WINE_TRY_PE_CFLAGS([-msse]) + WINE_TRY_PE_CFLAGS([-msse2]) + WINE_TRY_PE_CFLAGS([-mfxsr])
`-msse2` is fine, but I'm not sure I see the point of the other flags. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/10953#note_142131
participants (3)
-
Alexandre Julliard (@julliard) -
Matteo Bruni -
Matteo Bruni (@Mystral)