[PATCH 0/1] MR1395: dbghelp: Add SymAddrIncludeInlineTrace stub.

[Mohamad Al-Jaf (＠maljaf)]

Football Manager 2023 Editor calls this function.

The header already includes the prototype.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/1395

[PATCH 1/1] dbghelp: Add SymAddrIncludeInlineTrace stub.

[Mohamad Al-Jaf]

From: Mohamad Al-Jaf <mohamadaljaf(a)gmail.com>

Football Manager 2023 Editor calls this function.
---
 dlls/dbghelp/dbghelp.spec |  2 +-
 dlls/dbghelp/symbol.c     | 10 ++++++++++
 2 files changed, 11 insertions(+), 1 deletion(-)

diff --git a/dlls/dbghelp/dbghelp.spec b/dlls/dbghelp/dbghelp.spec
index 754fb456611..336a6f7aefd 100644
--- a/dlls/dbghelp/dbghelp.spec
+++ b/dlls/dbghelp/dbghelp.spec
@@ -38,7 +38,7 @@
 @ stub SymAddSourceStreamW
 @ stdcall SymAddSymbol(ptr int64 str int64 long long)
 @ stdcall SymAddSymbolW(ptr int64 wstr int64 long long)
-@ stub SymAddrIncludeInlineTrace
+@ stdcall SymAddrIncludeInlineTrace(long int64)
 @ stdcall SymCleanup(long)
 @ stub SymCompareInlineTrace
 @ stub SymDeleteSymbol
diff --git a/dlls/dbghelp/symbol.c b/dlls/dbghelp/symbol.c
index c82b5b3d4ef..ec12839bdd4 100644
--- a/dlls/dbghelp/symbol.c
+++ b/dlls/dbghelp/symbol.c
@@ -1366,6 +1366,16 @@ static inline BOOL doSymEnumSymbols(HANDLE hProcess, ULONG64 BaseOfDll, PCWSTR M
     return sym_enum(hProcess, BaseOfDll, Mask, &se);
 }
 
+/***********************************************************************
+ *              SymAddrIncludeInlineTrace (DBGHELP.@)
+ */
+DWORD WINAPI SymAddrIncludeInlineTrace(HANDLE hProcess, DWORD64 addr)
+{
+    FIXME("(%p, %I64x): stub\n", hProcess, addr);
+    SetLastError(ERROR_CALL_NOT_IMPLEMENTED);
+    return 0;
+}
+
 /******************************************************************
  *		SymEnumSymbols (DBGHELP.@)
  *
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/1395

[eric pouech (＠epo)]

Hi

1) could you rather put the implementation in symbol.c near the other inline context related functions?
(at the end, just above SymSrvGetFileIndexInfo)?
2) is this the only DbgHelp's symbol missing for the app?

thanks

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/1395#note_16149