Re: [PATCH v2 0/2] MR10715: mf: Call GetCorrelatedTime without critical section.

[Nikolay Sivov (＠nsivov)]

Nikolay Sivov (@nsivov) commented about dlls/mf/clock.c:
> static void CALLBACK presentation_clock_timer_callback(IUnknown *context)
>  {
>      struct presentation_clock *clock = impl_from_IMFPresentationClock((IMFPresentationClock*)context);
> +    IMFPresentationTimeSource *time_source;
>      struct clock_timer *timer;
>      LONGLONG time, systime;
>
> -    EnterCriticalSection(&clock->cs);
> -    if (clock->time_source &&
> -            SUCCEEDED(IMFPresentationTimeSource_GetCorrelatedTime(clock->time_source, 0, &time, &systime)))
> +    if ((time_source = clock->time_source))
> +        IMFPresentationTimeSource_AddRef(time_source);
> +
> I think at least this part should still be protected.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/10715#note_139209