Re: [PATCH v5 0/2] MR10735: dsound: Create independent devices for each DirectSoundCreate call.
Matteo Bruni (@Mystral) commented about dlls/dsound/tests/dsound.c:
+ DSBCAPS bufcaps; + LONG vol; + + rc=DirectSoundCreate(NULL,&dso1,NULL); + ok(rc==DS_OK||rc==DSERR_NODRIVER||rc==DSERR_ALLOCATED||rc==E_FAIL, + "DirectSoundCreate() failed: %08lx\n",rc); + if (rc!=DS_OK) + return; + + rc=DirectSoundCreate(NULL,&dso2,NULL); + ok(rc==DS_OK||rc==DSERR_NODRIVER||rc==DSERR_ALLOCATED||rc==E_FAIL, + "DirectSoundCreate() failed: %08lx\n",rc); + if (rc!=DS_OK) { + IDirectSound_Release(dso1); + return; + } I think we should require the second `DirectSoundCreate()` call to return successfully if the first one goes through.
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/10735#note_137954
participants (1)
-
Matteo Bruni (@Mystral)