[PATCH 0/1] MR8303: msvcrt/tests: Add broken to new j modifier tests.

[Bernhard Übelacker]

Followup to ec8fda8372.

[Test pattern page](https://test.winehq.org/data/patterns.html#msvcrt:scanf)

[Testbot run with this patch](https://testbot.winehq.org/JobDetails.pl?Key=158655).

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/8303

[PATCH 1/1] msvcrt/tests: Add broken to new j modifier tests.

[Bernhard Übelacker]

From: Bernhard Übelacker <bernhardu(a)mailbox.org>

Followup to ec8fda8372.
---
 dlls/msvcrt/tests/scanf.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/dlls/msvcrt/tests/scanf.c b/dlls/msvcrt/tests/scanf.c
index b41f0d1d119..00dfec3d3b0 100644
--- a/dlls/msvcrt/tests/scanf.c
+++ b/dlls/msvcrt/tests/scanf.c
@@ -353,8 +353,8 @@ static void test_sscanf( void )
 
     result64 = 0;
     ret = p_sscanf("0xfefefefefefefefe", "%jx", &result64);
-    ok(ret == 1, "got %d\n", ret);
-    ok(result64 == 0xfefefefefefefefell, "got 0x%s\n", wine_dbgstr_longlong(result64));
+    ok(ret == 1 || broken(ret == 0) /* <= Win10-1709 */, "got %d\n", ret);
+    ok(result64 == 0xfefefefefefefefell || broken(ret == 0) /* <= Win10-1709 */, "got 0x%s\n", wine_dbgstr_longlong(result64));
 }
 
 static void test_sscanf_s(void)
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/8303

[Piotr Caban (＠piotr)]

Piotr Caban (@piotr) commented about dlls/msvcrt/tests/scanf.c:
> result64 = 0;
>      ret = p_sscanf("0xfefefefefefefefe", "%jx", &result64);
> -    ok(ret == 1, "got %d\n", ret);
> -    ok(result64 == 0xfefefefefefefefell, "got 0x%s\n", wine_dbgstr_longlong(result64));
> +    ok(ret == 1 || broken(ret == 0) /* <= Win10-1709 */, "got %d\n", ret);
> +    ok(result64 == 0xfefefefefefefefell || broken(ret == 0) /* <= Win10-1709 */, "got 0x%s\n", wine_dbgstr_longlong(result64));

You're effectively disabling the test on Windows. Since there are no new exports added to msvcrt (so there's no easy way to skip the test) I think it's better to remove it. The functionality is tested in ucrtbase.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/8303#note_106493