[PATCH v2 0/1] MR10525: server: Do not return STATUS_ACCESS_DENIED from read_process_memory_vm() for zero read.

[Paul Gofman (＠gofman)]

--
  v2: server: Do not return STATUS_ACCESS_DENIED from read_process_memory_vm() for zero read.
 
https://gitlab.winehq.org/wine/wine/-/merge_requests/10525

[PATCH v2 1/1] server: Do not return STATUS_ACCESS_DENIED from read_process_memory_vm() for zero read.

[Paul Gofman]

From: Paul Gofman <[e-mail]>

---
 dlls/ntdll/tests/info.c | 5 +----
 server/ptrace.c         | 2 +-
 2 files changed, 2 insertions(+), 5 deletions(-)

diff --git a/dlls/ntdll/tests/info.c b/dlls/ntdll/tests/info.c
index 3d4c7d956f8..3b133ce1c69 100644
--- a/dlls/ntdll/tests/info.c
+++ b/dlls/ntdll/tests/info.c
@@ -2876,12 +2876,9 @@ static void test_readvirtualmemory(void)
     ok( strcmp(teststring, buffer) == 0, "Expected read memory to be the same as original memory\n");
 
     /* illegal remote address */
-    todo_wine{
     status = pNtReadVirtualMemory(process, (void *) 0x1234, buffer, 12, &readcount);
     ok( status == STATUS_PARTIAL_COPY, "Expected STATUS_PARTIAL_COPY, got %08lx\n", status);
-    if (status == STATUS_PARTIAL_COPY)
-        ok( readcount == 0, "Expected to read 0 bytes, got %Id\n",readcount);
-    }
+    ok( readcount == 0, "Expected to read 0 bytes, got %Id\n",readcount);
 
     /* 0 handle */
     status = pNtReadVirtualMemory(0, teststring, buffer, 12, &readcount);
diff --git a/server/ptrace.c b/server/ptrace.c
index bfebeca2271..a8fb85a1794 100644
--- a/server/ptrace.c
+++ b/server/ptrace.c
@@ -366,7 +366,7 @@ static int read_process_memory_vm( struct thread *thread, client_ptr_t ptr, data
         return -1;
     }
     if (len == size) return 1;
-    set_error( len >= 0 ? STATUS_PARTIAL_COPY : STATUS_ACCESS_DENIED );
+    set_error( STATUS_PARTIAL_COPY );
     return 0;
 }
 #else
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/10525

[Paul Gofman (＠gofman)]

v2:

* remove todo_wine from now succeeding tests in ntdll/tests/info.c:test_readvirtualmemory().

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/10525#note_134567