Re: [PATCH v2 0/1] MR8578: server: Allow for deletion of socket files.
July 21, 2025
10:44 a.m.
Loïc Rebmeister (@Fox2Code) commented about server/fd.c:
if (fd->unix_fd == -1) { + if (stat( name, &st )) + { + file_set_error(); + goto error; + }
I think the `stat` call should be moved after the "check for trailing slash on file path" code. As if the stat check is done here, the "check for trailing slash on file path" code path would no longer be called for `C:\NonExistingFolder\`. Everything else seems fine to me, I took my time reading to make sure I fully understood the code. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/8578#note_110527
248
Age (days ago)
248
Last active (days ago)
0 comments
1 participants
participants (1)
-
Loïc Rebmeister