Re: [PATCH v58 0/1] MR10192: kernelbase: Handle extended length path prefix in GetLongPathNameW

[Akihiro Sagawa (＠sgwaki)]

Akihiro Sagawa (@sgwaki) commented about dlls/kernelbase/file.c:
> +    /* Handle \\?\ prefix (Extended Length Path) */
> +    if (lstrlenW(shortpath) >= 4 && shortpath[0] == '\\' && shortpath[1] == '\\'
> +        && shortpath[2] == '?' && shortpath[3] == '\\')
> +    {
> +        if (wcsnicmp(shortpath + 4, L"UNC\\", 4) == 0)
> +        {
> +            FIXME("UNC Extended pathname %s\n", debugstr_w(shortpath));
> +            tmplen = lstrlenW(shortpath);
> +            if (tmplen < longlen)
> +            {
> +                if (longpath != shortpath) lstrcpyW(longpath, shortpath);
> +                return tmplen;
> +            }
> +            return tmplen + 1;
> +        }
> +        else if ( isalpha(shortpath[4]) && shortpath[5] == ':')
> I have some reservations about using `isalpha` with `WCHAR`, since its behavior is not defined for wide characters and may vary depending on the locale.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/10192#note_135664