[PATCH 0/1] MR11581: dinput/tests: Fix tests that are faulty because of == vs ?: operator precedence.
Split from https://gitlab.winehq.org/wine/wine/-/merge_requests/11566 with proper test fix as it was broken. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/11581
From: Brendan Shanks <bshanks@codeweavers.com> --- dlls/dinput/tests/hid.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dlls/dinput/tests/hid.c b/dlls/dinput/tests/hid.c index dfd35156f22..262bf082a4b 100644 --- a/dlls/dinput/tests/hid.c +++ b/dlls/dinput/tests/hid.c @@ -2610,7 +2610,7 @@ static void test_hidp( HANDLE file, HANDLE async_file, int report_id, BOOL polle ret = GetOverlappedResult( async_file, &overlapped, &value, TRUE ); ok( ret, "GetOverlappedResult failed, last error %lu\n", GetLastError() ); - ok( value == report_id ? 2 : caps.InputReportByteLength - 1, + ok( value == (report_id ? 2 : caps.InputReportByteLength - 1), "got length %lu, expected %u\n", value, report_id ? 2 : caps.InputReportByteLength - 1 ); CloseHandle( overlapped.hEvent ); -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/11581
This merge request was approved by Rémi Bernon. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/11581
participants (2)
-
Brendan Shanks -
Rémi Bernon (@rbernon)