[PATCH 0/1] MR4472: user32/tests: Add a trailing linefeed to ok() and skip() calls.
From: Francois Gouget <fgouget(a)free.fr> --- dlls/user32/tests/input.c | 2 +- dlls/user32/tests/monitor.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/dlls/user32/tests/input.c b/dlls/user32/tests/input.c index c5ffeadea5b..6a28bd24301 100644 --- a/dlls/user32/tests/input.c +++ b/dlls/user32/tests/input.c @@ -2591,7 +2591,7 @@ static LRESULT CALLBACK rawinput_wndproc(HWND hwnd, UINT msg, WPARAM wparam, LPA ret = GetRawInputData((HRAWINPUT)lparam, RID_INPUT, NULL, &raw_size, sizeof(RAWINPUTHEADER)); ok(ret == 0, "GetRawInputData failed\n"); - ok(raw_size <= sizeof(raw), "Unexpected rawinput data size: %u", raw_size); + ok(raw_size <= sizeof(raw), "Unexpected rawinput data size: %u\n", raw_size); raw_size = sizeof(raw); ret = GetRawInputData((HRAWINPUT)lparam, RID_INPUT, &raw, &raw_size, sizeof(RAWINPUTHEADER)); diff --git a/dlls/user32/tests/monitor.c b/dlls/user32/tests/monitor.c index 7131d1fe75f..d172eb900df 100644 --- a/dlls/user32/tests/monitor.c +++ b/dlls/user32/tests/monitor.c @@ -1791,7 +1791,7 @@ static void test_QueryDisplayConfig_result(UINT32 flags, /* Check corresponding modes */ if (pi[i].sourceInfo.modeInfoIdx == DISPLAYCONFIG_PATH_MODE_IDX_INVALID) { - skip("Path doesn't contain source modeInfoIdx"); + skip("Path doesn't contain source modeInfoIdx\n"); continue; } ok(pi[i].sourceInfo.modeInfoIdx < modes, "Expected index <%d, got %d\n", modes, pi[i].sourceInfo.modeInfoIdx); @@ -1814,7 +1814,7 @@ static void test_QueryDisplayConfig_result(UINT32 flags, if (pi[i].targetInfo.modeInfoIdx == DISPLAYCONFIG_PATH_MODE_IDX_INVALID) { - skip("Path doesn't contain target modeInfoIdx"); + skip("Path doesn't contain target modeInfoIdx\n"); continue; } ok(pi[i].targetInfo.modeInfoIdx < modes, "Expected index <%d, got %d\n", modes, pi[i].targetInfo.modeInfoIdx); -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/4472
Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=140167 Your paranoid android. === w1064v1809 (32 bit report) === user32: input.c:5064: Test failed: enable 1: GetPointerInfo failed, error 87 input.c:5072: Test failed: enable 1: got pointerType 3452816845 input.c:5074: Test failed: enable 1: got pointerId 3452816845 input.c:5077: Test failed: enable 1: got pointerFlags 0xcdcdcdcd input.c:5083: Test failed: enable 1: got hwndTarget CDCDCDCD input.c:5094: Test failed: enable 1: got historyCount 3452816845 input.c:5096: Test failed: enable 1: got InputData 3452816845 input.c:5098: Test failed: enable 1: got dwKeyStates 3452816845 input.c:5101: Test failed: enable 1: got ButtonChangeType 3452816845 input.c:5114: Test failed: enable 1: GetPointerFrameInfo failed, error 87 input.c:5116: Test failed: enable 1: got pointer_count 2 input.c:4934: Test failed: enable 1: got pointerType 0xa5a5a5a5 input.c:4935: Test failed: enable 1: got pointerId 0xa5a5a5a5 input.c:4936: Test failed: enable 1: got frameId 0xa5a5a5a5 input.c:4937: Test failed: enable 1: got pointerFlags 0xa5a5a5a5 input.c:4938: Test failed: enable 1: got sourceDevice A5A5A5A5 input.c:4939: Test failed: enable 1: got hwndTarget A5A5A5A5 input.c:4940: Test failed: enable 1: got ptPixelLocation.x -1515870811 input.c:4941: Test failed: enable 1: got ptPixelLocation.y -1515870811 input.c:4942: Test failed: enable 1: got ptHimetricLocation.x -1515870811 input.c:4943: Test failed: enable 1: got ptHimetricLocation.y -1515870811 input.c:4944: Test failed: enable 1: got ptPixelLocationRaw.x -1515870811 input.c:4945: Test failed: enable 1: got ptPixelLocationRaw.y -1515870811 input.c:4946: Test failed: enable 1: got ptHimetricLocationRaw.x -1515870811 input.c:4947: Test failed: enable 1: got ptHimetricLocationRaw.y -1515870811 input.c:4948: Test failed: enable 1: got dwTime 2779096485 input.c:4949: Test failed: enable 1: got historyCount 2779096485 input.c:4950: Test failed: enable 1: got InputData 0xa5a5a5a5 input.c:4951: Test failed: enable 1: got dwKeyStates 0xa5a5a5a5 input.c:4952: Test failed: enable 1: got PerformanceCount 11936128518282651045 input.c:4953: Test failed: enable 1: got ButtonChangeType 0xa5a5a5a5 input.c:5124: Test failed: enable 1: GetPointerInfoHistory failed, error 87 input.c:5126: Test failed: enable 1: got entry_count 2 input.c:4934: Test failed: enable 1: got pointerType 0xa5a5a5a5 input.c:4935: Test failed: enable 1: got pointerId 0xa5a5a5a5 input.c:4936: Test failed: enable 1: got frameId 0xa5a5a5a5 input.c:4937: Test failed: enable 1: got pointerFlags 0xa5a5a5a5 input.c:4938: Test failed: enable 1: got sourceDevice A5A5A5A5 input.c:4939: Test failed: enable 1: got hwndTarget A5A5A5A5 input.c:4940: Test failed: enable 1: got ptPixelLocation.x -1515870811 input.c:4941: Test failed: enable 1: got ptPixelLocation.y -1515870811 input.c:4942: Test failed: enable 1: got ptHimetricLocation.x -1515870811 input.c:4943: Test failed: enable 1: got ptHimetricLocation.y -1515870811 input.c:4944: Test failed: enable 1: got ptPixelLocationRaw.x -1515870811 input.c:4945: Test failed: enable 1: got ptPixelLocationRaw.y -1515870811 input.c:4946: Test failed: enable 1: got ptHimetricLocationRaw.x -1515870811 input.c:4947: Test failed: enable 1: got ptHimetricLocationRaw.y -1515870811 input.c:4948: Test failed: enable 1: got dwTime 2779096485 input.c:4949: Test failed: enable 1: got historyCount 2779096485 input.c:4950: Test failed: enable 1: got InputData 0xa5a5a5a5 input.c:4951: Test failed: enable 1: got dwKeyStates 0xa5a5a5a5 input.c:4952: Test failed: enable 1: got PerformanceCount 11936128518282651045 input.c:4953: Test failed: enable 1: got ButtonChangeType 0xa5a5a5a5 input.c:5134: Test failed: enable 1: GetPointerFrameInfoHistory failed, error 87 input.c:5136: Test failed: enable 1: got pointer_count 2 input.c:5138: Test failed: enable 1: got pointer_count 2 input.c:4934: Test failed: enable 1: got pointerType 0xa5a5a5a5 input.c:4935: Test failed: enable 1: got pointerId 0xa5a5a5a5 input.c:4936: Test failed: enable 1: got frameId 0xa5a5a5a5 input.c:4937: Test failed: enable 1: got pointerFlags 0xa5a5a5a5 input.c:4938: Test failed: enable 1: got sourceDevice A5A5A5A5 input.c:4939: Test failed: enable 1: got hwndTarget A5A5A5A5 input.c:4940: Test failed: enable 1: got ptPixelLocation.x -1515870811 input.c:4941: Test failed: enable 1: got ptPixelLocation.y -1515870811 input.c:4942: Test failed: enable 1: got ptHimetricLocation.x -1515870811 input.c:4943: Test failed: enable 1: got ptHimetricLocation.y -1515870811 input.c:4944: Test failed: enable 1: got ptPixelLocationRaw.x -1515870811 input.c:4945: Test failed: enable 1: got ptPixelLocationRaw.y -1515870811 input.c:4946: Test failed: enable 1: got ptHimetricLocationRaw.x -1515870811 input.c:4947: Test failed: enable 1: got ptHimetricLocationRaw.y -1515870811 input.c:4948: Test failed: enable 1: got dwTime 2779096485 input.c:4949: Test failed: enable 1: got historyCount 2779096485 input.c:4950: Test failed: enable 1: got InputData 0xa5a5a5a5 input.c:4951: Test failed: enable 1: got dwKeyStates 0xa5a5a5a5 input.c:4952: Test failed: enable 1: got PerformanceCount 11936128518282651045 input.c:4953: Test failed: enable 1: got ButtonChangeType 0xa5a5a5a5
participants (3)
-
Francois Gouget -
Francois Gouget (＠fgouget)
-
Marvin