[PATCH 0/1] MR1893: increase number of midi ports to 64
While this doesn't fully fix https://bugs.winehq.org/show_bug.cgi?id=50703 as we can read in the code comments ideally the number of devices is "unbound" it does resolve the immediate issue that I've been facing. Since the total number of ports displayed is both hardware + software it's incredibly easy to go beyond just 16. The increase to 64 helps a lot, but is still not perfect. We could also set it to 128 or 256, but it's still arbitrary. I think this would already be enough for the vast majority of cases, but I guess they also thought this with 16 ;) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1893
From: dreamer <dreamer(a)puikheid.nl> --- include/mmddk.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/mmddk.h b/include/mmddk.h index d4217f2ebef..02115754f1a 100644 --- a/include/mmddk.h +++ b/include/mmddk.h @@ -30,13 +30,13 @@ extern "C" { #endif -#define MAX_MIDIINDRV (16) +#define MAX_MIDIINDRV (64) /* For now I'm making 16 the maximum number of midi devices one can * have. This should be more than enough for everybody. But as a purist, * I intend to make it unbounded in the future, as soon as I figure * a good way to do so. */ -#define MAX_MIDIOUTDRV (16) +#define MAX_MIDIOUTDRV (64) /* ================================== * Multimedia DDK compatible part -- GitLab https://gitlab.winehq.org/wine/wine/-/merge_requests/1893
On 12/30/22 05:49, dreamer wrote:
From: dreamer <dreamer(a)puikheid.nl>
-#define MAX_MIDIINDRV (16) +#define MAX_MIDIINDRV (64) /* For now I'm making 16 the maximum number of midi devices one can * have. This should be more than enough for everybody. But as a purist, * I intend to make it unbounded in the future, as soon as I figure * a good way to do so. */ -#define MAX_MIDIOUTDRV (16) +#define MAX_MIDIOUTDRV (64)
Should probably update the comment too, since that still says there's a max of 16.
On Fri Dec 30 14:11:06 2022 +0000, **** wrote:
Chris Robinson replied on the mailing list: ``` On 12/30/22 05:49, dreamer wrote:
From: dreamer <dreamer(a)puikheid.nl>
-#define MAX_MIDIINDRV (16) +#define MAX_MIDIINDRV (64) /* For now I'm making 16 the maximum number of midi devices one can * have. This should be more than enough for everybody. But as a purist, * I intend to make it unbounded in the future, as soon as I figure * a good way to do so. */ -#define MAX_MIDIOUTDRV (16) +#define MAX_MIDIOUTDRV (64) Should probably update the comment too, since that still says there's a max of 16.
Correct :smile:
-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1893#note_20206
participants (3)
-
Alexander (＠dreamer) -
Chris Robinson -
dreamer