[PATCH 0/1] MR2085: Add merge request template.

[Bernhard Kölbl]

Not sure if we want this, just wanted to bring the idea in.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/2085

[PATCH 1/1] gitlab: Add merge request template.

[Bernhard Kölbl]

From: Bernhard Kölbl <besentv(a)gmail.com>

---
 .gitlab/merge_request_templates/default.md | 8 ++++++++
 1 file changed, 8 insertions(+)
 create mode 100644 .gitlab/merge_request_templates/default.md

diff --git a/.gitlab/merge_request_templates/default.md b/.gitlab/merge_request_templates/default.md
new file mode 100644
index 00000000000..67193876461
--- /dev/null
+++ b/.gitlab/merge_request_templates/default.md
@@ -0,0 +1,8 @@
+### Before sumbitting a merge request, I made sure to:
+
+- read through the patch submission guide: https://wiki.winehq.org/Submitting_Patches
+- put my real name on my Gitlab profile.
+- commit my patches with the same name locally, as provided on Gitlab. (See: https://wiki.winehq.org/Git_Wine_Tutorial)
+- not provide any disassemled or reverse engineered parts of Windows code. This includes ReactOS code.
+- follow the basic style guidelines: https://wiki.winehq.org/Wine_Developer%27s_Guide/Coding_Practice#Some_notes_...
+- write regression tests for my patches, if needed.
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/2085

[Jinoh Kang (＠iamahuman)]

Ideally, we would like to rely on automation instead of adding extra burden to both new contributors and old-timers.
> - read through the patch submission guide: https://wiki.winehq.org/Submitting_Patches
> - put my real name on my Gitlab profile.
> - not provide any disassemled or reverse engineered parts of Windows code. This includes ReactOS code.

This can be replaced by a CLA assistant bot, since these actions are expected to be taken once by the contributor.
> - commit my patches with the same name locally, as provided on Gitlab. (See: https://wiki.winehq.org/Git_Wine_Tutorial)
> - follow the basic style guidelines: https://wiki.winehq.org/Wine_Developer%27s_Guide/Coding_Practice#Some_notes_...

This can be replaced by CI automation with a lint stage.
> - write regression tests for my patches, if needed.

This can probably be replaced by a bot that reminds the contributor to add tests if a patch that exceeds certain SLoC or cyclomatic complexity delta threshold is detected.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/2085#note_23060

[PATCH 0/1] MR2085: Add merge request template. - closed

[Bernhard Kölbl]

This merge request was closed by Bernhard Kölbl.
-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/2085