[PATCH 0/1] MR10888: riched20: Implement EM_LINELENGTH with wParam==-1

[Rose Hellsing (＠axtlos)]

MS Comic Chat requires EM_LINELENGTH with wParam==-1 to be implemented in riched20 to allow typing space characters.

EM_LINELENGTH(-1) returns the number of unselected characters on the line that contains the current selection.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/10888

[PATCH 1/1] riched20: Implement EM_LINELENGTH with wParam==-1

[Rose Hellsing]

From: Rose Hellsing <[e-mail]>

MS Comic Chat requires EM_LINELENGTH with wParam==-1 to be implemented in riched20 to allow typing space characters.

EM_LINELENGTH(-1) returns the number of unselected characters on the line that contains the current selection.
---
 dlls/riched20/editor.c | 26 ++++++++++++++++++++++----
 1 file changed, 22 insertions(+), 4 deletions(-)

diff --git a/dlls/riched20/editor.c b/dlls/riched20/editor.c
index 1a0c444579b..e704508f2a5 100644
--- a/dlls/riched20/editor.c
+++ b/dlls/riched20/editor.c
@@ -3806,13 +3806,31 @@ LRESULT editor_handle_message( ME_TextEditor *editor, UINT msg, WPARAM wParam,
     int start_ofs, end_ofs;
     ME_Cursor cursor;
 
-    if (wParam > ME_GetTextLength(editor))
-      return 0;
     if (wParam == -1)
     {
-      FIXME("EM_LINELENGTH: returning number of unselected characters on lines with selection unsupported.\n");
-      return 0;
+      LONG from, to;
+      int line_start, line_end, line_len, result;
+
+      ME_GetSelectionOfs( editor, &from, &to );
+
+      cursor_from_char_ofs( editor, from, &cursor );
+      row = row_from_cursor( &cursor );
+      row_first_cursor( row, &cursor );
+      line_start = ME_GetCursorOfs( &cursor );
+
+      cursor_from_char_ofs( editor, to, &cursor );
+      row = row_from_cursor( &cursor );
+      row_first_cursor( row, &cursor );
+      line_end = ME_GetCursorOfs( &cursor );
+      row_end_cursor( row, &cursor, FALSE );
+      line_len = ME_GetCursorOfs( &cursor ) - line_end;
+
+      result = (from - line_start) + (line_end + line_len - to);
+      TRACE( "EM_LINELENGTH(-1): sel=%ld..%ld result=%d\n", from, to, result );
+      return result;
     }
+    if (wParam > ME_GetTextLength(editor))
+      return 0;
     cursor_from_char_ofs( editor, wParam, &cursor );
     row = row_from_cursor( &cursor );
     row_first_cursor( row, &cursor );
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/10888

[Rose Hellsing (＠axtlos)]

I didn't find a wine bug for this, only mention I discovered was at https://shadowm00n.neocities.org/tech/comic_chat

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/10888#note_139728

[Huw Davies (＠huw)]

Could we have a test for this please?  There are already `EM_LINELENGTH` tests in `test_EM_LINELENGTH()`.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/10888#note_139788