[PATCH 0/2] MR4420: msi: Clang warning fixes.

[Jacek Caban (＠jacek)]

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/4420

[PATCH 1/2] msi: Store Context as MSIINSTALLCONTEXT in MSIPACKAGE.

[Jacek Caban]

From: Jacek Caban <jacek(a)codeweavers.com>

Avoids casting to enum pointer in msi_locate_product call.
---
 dlls/msi/msipriv.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/msi/msipriv.h b/dlls/msi/msipriv.h
index 85cc5e257a7..4c2f2ae2589 100644
--- a/dlls/msi/msipriv.h
+++ b/dlls/msi/msipriv.h
@@ -456,7 +456,7 @@ typedef struct tagMSIPACKAGE
     float center_y;
 
     UINT WordCount;
-    UINT Context;
+    MSIINSTALLCONTEXT Context;
 
     struct list subscriptions;
 
-- 
GitLab


https://gitlab.winehq.org/wine/wine/-/merge_requests/4420

[PATCH 2/2] msi/tests: Initialize pathkey in test_installprops.

[Jacek Caban]

From: Jacek Caban <jacek(a)codeweavers.com>

It could be used uninitialized on early no access return.
---
 dlls/msi/tests/package.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/msi/tests/package.c b/dlls/msi/tests/package.c
index 3d7569499e5..75bb330db9d 100644
--- a/dlls/msi/tests/package.c
+++ b/dlls/msi/tests/package.c
@@ -5583,7 +5583,7 @@ static void test_installprops(void)
     CHAR path[MAX_PATH], buf[MAX_PATH];
     DWORD size, type;
     LANGID langid;
-    HKEY hkey1, hkey2, pathkey;
+    HKEY hkey1, hkey2, pathkey = NULL;
     int res;
     UINT r;
     REGSAM access = KEY_ALL_ACCESS;
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/4420

[PATCH 0/2] MR4420: msi: Clang warning fixes. - approved

[Hans Leidekker (＠hans)]

This merge request was approved by Hans Leidekker.
-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/4420