[PATCH 0/1] MR11275: server: Fix a memory leak in d3dkmt_share_objects.

[Zhiyi Zhang (＠zhiyi)]

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/11275

[PATCH 1/1] server: Fix a memory leak in d3dkmt_share_objects.

[Zhiyi Zhang]

From: Zhiyi Zhang <[e-mail]>

---
 server/d3dkmt.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/server/d3dkmt.c b/server/d3dkmt.c
index e913e112911..bd0e879f4f3 100644
--- a/server/d3dkmt.c
+++ b/server/d3dkmt.c
@@ -696,7 +696,7 @@ DECL_HANDLER(d3dkmt_share_objects)
     {
         struct dxgk_shared_resource *shared;
 
-        if (!(resource = d3dkmt_object_open( req->resource, D3DKMT_RESOURCE ))) return;
+        if (!(resource = d3dkmt_object_open( req->resource, D3DKMT_RESOURCE ))) goto done;
         if (req->mutex && !(mutex = d3dkmt_object_open( req->mutex, D3DKMT_MUTEX ))) goto done;
         if (req->sync && !(sync = d3dkmt_object_open( req->sync, D3DKMT_SYNC ))) goto done;
 
@@ -711,7 +711,7 @@ DECL_HANDLER(d3dkmt_share_objects)
     {
         struct dxgk_shared_sync *shared;
 
-        if (!(sync = d3dkmt_object_open( req->sync, D3DKMT_SYNC ))) return;
+        if (!(sync = d3dkmt_object_open( req->sync, D3DKMT_SYNC ))) goto done;
 
         if (!(shared = create_named_object( root, &dxgk_shared_sync_ops, &name, objattr->attributes | OBJ_CASE_INSENSITIVE, NULL ))) goto done;
         shared->sync = grab_object( sync );
@@ -720,6 +720,7 @@ DECL_HANDLER(d3dkmt_share_objects)
     }
 
 done:
+    if (root) release_object( root );
     if (resource) release_object( resource );
     if (mutex) release_object( mutex );
     if (sync) release_object( sync );
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/11275

[PATCH 0/1] MR11275: server: Fix a memory leak in d3dkmt_share_objects. - approved

[Rémi Bernon (＠rbernon)]

This merge request was approved by Rémi Bernon.
-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/11275