[PATCH 0/1] MR10889: ole32: Validate cached clipboard window handle in get_clipbrd_window.

[Aaron Yourk (＠ayourk)]

The OLE clipboard caches a per-process window handle. When the STA 
thread that created this window terminates, the window is destroyed 
but the stale handle remains cached. Subsequent OleSetClipboard 
calls use this stale handle, causing OpenClipboard to fail with 
CLIPBRD_E_CANT_OPEN.

Check whether the cached window is still valid using IsWindow() 
before returning it. If the window has been destroyed, clear the 
cache so a fresh window is created on the current thread. 

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=59519

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/10889

[PATCH 1/1] ole32: Validate cached clipboard window handle in get_clipbrd_window.

[Aaron Yourk]

From: Aaron Yourk <[e-mail]>

The OLE clipboard caches a per-process window handle. When the STA
thread that created this window terminates, the window is destroyed
but the stale handle remains cached. Subsequent OleSetClipboard
calls use this stale handle, causing OpenClipboard to fail with
CLIPBRD_E_CANT_OPEN.

Check whether the cached window is still valid using IsWindow()
before returning it. If the window has been destroyed, clear the
cache so a fresh window is created on the current thread.

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=59519
---
 dlls/ole32/clipboard.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/dlls/ole32/clipboard.c b/dlls/ole32/clipboard.c
index c54608985fb..749dd03c3e6 100644
--- a/dlls/ole32/clipboard.c
+++ b/dlls/ole32/clipboard.c
@@ -1899,6 +1899,9 @@ static HWND create_clipbrd_window(void);
  */
 static inline HRESULT get_clipbrd_window(ole_clipbrd *clipbrd, HWND *wnd)
 {
+    if ( clipbrd->window && !IsWindow(clipbrd->window) )
+        clipbrd->window = NULL;
+
     if ( !clipbrd->window )
         clipbrd->window = create_clipbrd_window();
 
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/10889