[PATCH v5 0/4] MR1090: msvcrt: implement missing CRT functions to fix ChessBase 14 crash

[Bartosz Kosiorek (＠gang65)]

_mbctolower_l - converts multibyte uppercase character to lowercase character, by using specified locale that's passed in.

More information about these methods are available at:
https://learn.microsoft.com/en-us/cpp/c-runtime-library/reference/mbctolower...

More information about application crash:
https://bugs.winehq.org/show_bug.cgi?id=45273

--
  v5: msvcrt: Add _mbsupr_s_l partial implementation.
      msvcrt: Add _mbslwr_s_l partial implementation.
 
https://gitlab.winehq.org/wine/wine/-/merge_requests/1090

[PATCH v5 1/4] msvcrt: Add _mbctolower_l partial implementation.

[Bartosz Kosiorek]

From: Bartosz Kosiorek <gang65(a)poczta.onet.pl>

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=45273
---
 dlls/msvcr100/msvcr100.spec |  2 +-
 dlls/msvcr110/msvcr110.spec |  2 +-
 dlls/msvcr120/msvcr120.spec |  2 +-
 dlls/msvcr80/msvcr80.spec   |  2 +-
 dlls/msvcr90/msvcr90.spec   |  2 +-
 dlls/msvcrt/mbcs.c          | 16 ++++++++++++----
 dlls/ucrtbase/ucrtbase.spec |  2 +-
 7 files changed, 18 insertions(+), 10 deletions(-)

diff --git a/dlls/msvcr100/msvcr100.spec b/dlls/msvcr100/msvcr100.spec
index c0bbbc5b86d..648092da5a4 100644
--- a/dlls/msvcr100/msvcr100.spec
+++ b/dlls/msvcr100/msvcr100.spec
@@ -1088,7 +1088,7 @@
 @ cdecl _mbctokata(long)
 @ stub _mbctokata_l
 @ cdecl _mbctolower(long)
-@ stub _mbctolower_l
+@ cdecl _mbctolower_l(long ptr)
 @ cdecl _mbctombb(long)
 @ stub _mbctombb_l
 @ cdecl _mbctoupper(long)
diff --git a/dlls/msvcr110/msvcr110.spec b/dlls/msvcr110/msvcr110.spec
index a272ae98a1c..03d96e91d86 100644
--- a/dlls/msvcr110/msvcr110.spec
+++ b/dlls/msvcr110/msvcr110.spec
@@ -1445,7 +1445,7 @@
 @ cdecl _mbctokata(long)
 @ stub _mbctokata_l
 @ cdecl _mbctolower(long)
-@ stub _mbctolower_l
+@ cdecl _mbctolower_l(long ptr)
 @ cdecl _mbctombb(long)
 @ stub _mbctombb_l
 @ cdecl _mbctoupper(long)
diff --git a/dlls/msvcr120/msvcr120.spec b/dlls/msvcr120/msvcr120.spec
index d16316e7e05..8eb007f3945 100644
--- a/dlls/msvcr120/msvcr120.spec
+++ b/dlls/msvcr120/msvcr120.spec
@@ -1456,7 +1456,7 @@
 @ cdecl _mbctokata(long)
 @ stub _mbctokata_l
 @ cdecl _mbctolower(long)
-@ stub _mbctolower_l
+@ cdecl _mbctolower_l(long ptr)
 @ cdecl _mbctombb(long)
 @ stub _mbctombb_l
 @ cdecl _mbctoupper(long)
diff --git a/dlls/msvcr80/msvcr80.spec b/dlls/msvcr80/msvcr80.spec
index 371d17ecc21..b0c81808198 100644
--- a/dlls/msvcr80/msvcr80.spec
+++ b/dlls/msvcr80/msvcr80.spec
@@ -760,7 +760,7 @@
 @ cdecl _mbctokata(long)
 @ stub _mbctokata_l
 @ cdecl _mbctolower(long)
-@ stub _mbctolower_l
+@ cdecl _mbctolower_l(long ptr)
 @ cdecl _mbctombb(long)
 @ stub _mbctombb_l
 @ cdecl _mbctoupper(long)
diff --git a/dlls/msvcr90/msvcr90.spec b/dlls/msvcr90/msvcr90.spec
index dc9d4ae097b..f0b6e43b33c 100644
--- a/dlls/msvcr90/msvcr90.spec
+++ b/dlls/msvcr90/msvcr90.spec
@@ -738,7 +738,7 @@
 @ cdecl _mbctokata(long)
 @ stub _mbctokata_l
 @ cdecl _mbctolower(long)
-@ stub _mbctolower_l
+@ cdecl _mbctolower_l(long ptr)
 @ cdecl _mbctombb(long)
 @ stub _mbctombb_l
 @ cdecl _mbctoupper(long)
diff --git a/dlls/msvcrt/mbcs.c b/dlls/msvcrt/mbcs.c
index dc9abca1b44..3230a9fc084 100644
--- a/dlls/msvcrt/mbcs.c
+++ b/dlls/msvcrt/mbcs.c
@@ -447,16 +447,24 @@ unsigned int CDECL _mbsnextc(const unsigned char* str)
 }
 
 /*********************************************************************
- *		_mbctolower(MSVCRT.@)
+ *		_mbctolower_l(MSVCRT.@)
  */
-unsigned int CDECL _mbctolower(unsigned int c)
+unsigned int CDECL _mbctolower_l(unsigned int c, _locale_t locale)
 {
-    if (_ismbblead(c))
+    if (_ismbblead_l(c, locale))
     {
       FIXME("Handle MBC chars\n");
       return c;
     }
-    return _tolower_l(c, NULL); /* ASCII CP or SB char */
+    return _tolower_l(c, locale); /* ASCII CP or SB char */
+}
+
+/*********************************************************************
+ *		_mbctolower(MSVCRT.@)
+ */
+unsigned int CDECL _mbctolower(unsigned int c)
+{
+    return _mbctolower_l(c, NULL);
 }
 
 /*********************************************************************
diff --git a/dlls/ucrtbase/ucrtbase.spec b/dlls/ucrtbase/ucrtbase.spec
index a4acf724d2f..f85309a7b42 100644
--- a/dlls/ucrtbase/ucrtbase.spec
+++ b/dlls/ucrtbase/ucrtbase.spec
@@ -603,7 +603,7 @@
 @ cdecl _mbctokata(long)
 @ stub _mbctokata_l
 @ cdecl _mbctolower(long)
-@ stub _mbctolower_l
+@ cdecl _mbctolower_l(long ptr)
 @ cdecl _mbctombb(long)
 @ stub _mbctombb_l
 @ cdecl _mbctoupper(long)
-- 
GitLab


https://gitlab.winehq.org/wine/wine/-/merge_requests/1090

[PATCH v5 2/4] msvcrt: Add _mbctoupper_l partial implementation.

[Bartosz Kosiorek]

From: Bartosz Kosiorek <gang65(a)poczta.onet.pl>

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=45273
---
 dlls/msvcr100/msvcr100.spec |  2 +-
 dlls/msvcr110/msvcr110.spec |  2 +-
 dlls/msvcr120/msvcr120.spec |  2 +-
 dlls/msvcr80/msvcr80.spec   |  2 +-
 dlls/msvcr90/msvcr90.spec   |  2 +-
 dlls/msvcrt/mbcs.c          | 16 ++++++++++++----
 dlls/ucrtbase/ucrtbase.spec |  2 +-
 7 files changed, 18 insertions(+), 10 deletions(-)

diff --git a/dlls/msvcr100/msvcr100.spec b/dlls/msvcr100/msvcr100.spec
index 648092da5a4..b3fd1af1ecb 100644
--- a/dlls/msvcr100/msvcr100.spec
+++ b/dlls/msvcr100/msvcr100.spec
@@ -1092,7 +1092,7 @@
 @ cdecl _mbctombb(long)
 @ stub _mbctombb_l
 @ cdecl _mbctoupper(long)
-@ stub _mbctoupper_l
+@ cdecl _mbctoupper_l(long ptr)
 @ extern _mbctype MSVCRT_mbctype
 @ stub _mblen_l
 @ cdecl _mbsbtype(str long)
diff --git a/dlls/msvcr110/msvcr110.spec b/dlls/msvcr110/msvcr110.spec
index 03d96e91d86..28e5e047090 100644
--- a/dlls/msvcr110/msvcr110.spec
+++ b/dlls/msvcr110/msvcr110.spec
@@ -1449,7 +1449,7 @@
 @ cdecl _mbctombb(long)
 @ stub _mbctombb_l
 @ cdecl _mbctoupper(long)
-@ stub _mbctoupper_l
+@ cdecl _mbctoupper_l(long ptr)
 @ extern _mbctype MSVCRT_mbctype
 @ stub _mblen_l
 @ cdecl _mbsbtype(str long)
diff --git a/dlls/msvcr120/msvcr120.spec b/dlls/msvcr120/msvcr120.spec
index 8eb007f3945..ae4874a7116 100644
--- a/dlls/msvcr120/msvcr120.spec
+++ b/dlls/msvcr120/msvcr120.spec
@@ -1460,7 +1460,7 @@
 @ cdecl _mbctombb(long)
 @ stub _mbctombb_l
 @ cdecl _mbctoupper(long)
-@ stub _mbctoupper_l
+@ cdecl _mbctoupper_l(long ptr)
 @ extern _mbctype MSVCRT_mbctype
 @ stub _mblen_l
 @ cdecl _mbsbtype(str long)
diff --git a/dlls/msvcr80/msvcr80.spec b/dlls/msvcr80/msvcr80.spec
index b0c81808198..7b484d8be26 100644
--- a/dlls/msvcr80/msvcr80.spec
+++ b/dlls/msvcr80/msvcr80.spec
@@ -764,7 +764,7 @@
 @ cdecl _mbctombb(long)
 @ stub _mbctombb_l
 @ cdecl _mbctoupper(long)
-@ stub _mbctoupper_l
+@ cdecl _mbctoupper_l(long ptr)
 @ extern _mbctype MSVCRT_mbctype
 @ stub _mblen_l
 @ cdecl _mbsbtype(str long)
diff --git a/dlls/msvcr90/msvcr90.spec b/dlls/msvcr90/msvcr90.spec
index f0b6e43b33c..ab1ef139f9a 100644
--- a/dlls/msvcr90/msvcr90.spec
+++ b/dlls/msvcr90/msvcr90.spec
@@ -742,7 +742,7 @@
 @ cdecl _mbctombb(long)
 @ stub _mbctombb_l
 @ cdecl _mbctoupper(long)
-@ stub _mbctoupper_l
+@ cdecl _mbctoupper_l(long ptr)
 @ extern _mbctype MSVCRT_mbctype
 @ stub _mblen_l
 @ cdecl _mbsbtype(str long)
diff --git a/dlls/msvcrt/mbcs.c b/dlls/msvcrt/mbcs.c
index 3230a9fc084..7073fee5bfd 100644
--- a/dlls/msvcrt/mbcs.c
+++ b/dlls/msvcrt/mbcs.c
@@ -468,16 +468,24 @@ unsigned int CDECL _mbctolower(unsigned int c)
 }
 
 /*********************************************************************
- *		_mbctoupper(MSVCRT.@)
+ *		_mbctoupper_l(MSVCRT.@)
  */
-unsigned int CDECL _mbctoupper(unsigned int c)
+unsigned int CDECL _mbctoupper_l(unsigned int c, _locale_t locale)
 {
-    if (_ismbblead(c))
+    if (_ismbblead_l(c, locale))
     {
       FIXME("Handle MBC chars\n");
       return c;
     }
-    return _toupper_l(c, NULL); /* ASCII CP or SB char */
+    return _toupper_l(c, locale); /* ASCII CP or SB char */
+}
+
+/*********************************************************************
+ *		_mbctoupper(MSVCRT.@)
+ */
+unsigned int CDECL _mbctoupper(unsigned int c)
+{
+    return _mbctoupper_l(c, NULL);
 }
 
 /*********************************************************************
diff --git a/dlls/ucrtbase/ucrtbase.spec b/dlls/ucrtbase/ucrtbase.spec
index f85309a7b42..c803799f4cd 100644
--- a/dlls/ucrtbase/ucrtbase.spec
+++ b/dlls/ucrtbase/ucrtbase.spec
@@ -607,7 +607,7 @@
 @ cdecl _mbctombb(long)
 @ stub _mbctombb_l
 @ cdecl _mbctoupper(long)
-@ stub _mbctoupper_l
+@ cdecl _mbctoupper_l(long ptr)
 @ stub _mblen_l
 @ cdecl _mbsbtype(str long)
 @ stub _mbsbtype_l
-- 
GitLab


https://gitlab.winehq.org/wine/wine/-/merge_requests/1090

[PATCH v5 4/4] msvcrt: Add _mbsupr_s_l partial implementation.

[Bartosz Kosiorek]

From: Bartosz Kosiorek <gang65(a)poczta.onet.pl>

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=45273
---
 dlls/msvcr100/msvcr100.spec |  2 +-
 dlls/msvcr110/msvcr110.spec |  2 +-
 dlls/msvcr120/msvcr120.spec |  2 +-
 dlls/msvcr80/msvcr80.spec   |  2 +-
 dlls/msvcr90/msvcr90.spec   |  2 +-
 dlls/msvcrt/mbcs.c          | 21 +++++++++++++++------
 dlls/msvcrt/tests/string.c  |  7 +++++++
 dlls/ucrtbase/ucrtbase.spec |  2 +-
 8 files changed, 28 insertions(+), 12 deletions(-)

diff --git a/dlls/msvcr100/msvcr100.spec b/dlls/msvcr100/msvcr100.spec
index 90accd39722..b051cf6a77f 100644
--- a/dlls/msvcr100/msvcr100.spec
+++ b/dlls/msvcr100/msvcr100.spec
@@ -1202,7 +1202,7 @@
 @ cdecl _mbsupr(str)
 @ stub _mbsupr_l
 @ cdecl _mbsupr_s(str long)
-@ stub _mbsupr_s_l
+@ cdecl _mbsupr_s_l(str long ptr)
 @ cdecl _mbtowc_l(ptr str long ptr)
 @ cdecl _memccpy(ptr ptr long long)
 @ cdecl _memicmp(str str long)
diff --git a/dlls/msvcr110/msvcr110.spec b/dlls/msvcr110/msvcr110.spec
index 5ca3156ab0b..593df178536 100644
--- a/dlls/msvcr110/msvcr110.spec
+++ b/dlls/msvcr110/msvcr110.spec
@@ -1559,7 +1559,7 @@
 @ cdecl _mbsupr(str)
 @ stub _mbsupr_l
 @ cdecl _mbsupr_s(str long)
-@ stub _mbsupr_s_l
+@ cdecl _mbsupr_s_l(str long ptr)
 @ cdecl _mbtowc_l(ptr str long ptr)
 @ cdecl _memccpy(ptr ptr long long)
 @ cdecl _memicmp(str str long)
diff --git a/dlls/msvcr120/msvcr120.spec b/dlls/msvcr120/msvcr120.spec
index a514febaa21..cd92da9a8d7 100644
--- a/dlls/msvcr120/msvcr120.spec
+++ b/dlls/msvcr120/msvcr120.spec
@@ -1570,7 +1570,7 @@
 @ cdecl _mbsupr(str)
 @ stub _mbsupr_l
 @ cdecl _mbsupr_s(str long)
-@ stub _mbsupr_s_l
+@ cdecl _mbsupr_s_l(str long ptr)
 @ cdecl _mbtowc_l(ptr str long ptr)
 @ cdecl _memccpy(ptr ptr long long)
 @ cdecl _memicmp(str str long)
diff --git a/dlls/msvcr80/msvcr80.spec b/dlls/msvcr80/msvcr80.spec
index 9c2498781f0..de0da8e26e9 100644
--- a/dlls/msvcr80/msvcr80.spec
+++ b/dlls/msvcr80/msvcr80.spec
@@ -874,7 +874,7 @@
 @ cdecl _mbsupr(str)
 @ stub _mbsupr_l
 @ cdecl _mbsupr_s(str long)
-@ stub _mbsupr_s_l
+@ cdecl _mbsupr_s_l(str long ptr)
 @ cdecl _mbtowc_l(ptr str long ptr)
 @ cdecl _memccpy(ptr ptr long long)
 @ cdecl _memicmp(str str long)
diff --git a/dlls/msvcr90/msvcr90.spec b/dlls/msvcr90/msvcr90.spec
index ae1add4cb5f..d5f94a65f78 100644
--- a/dlls/msvcr90/msvcr90.spec
+++ b/dlls/msvcr90/msvcr90.spec
@@ -852,7 +852,7 @@
 @ cdecl _mbsupr(str)
 @ stub _mbsupr_l
 @ cdecl _mbsupr_s(str long)
-@ stub _mbsupr_s_l
+@ cdecl _mbsupr_s_l(str long ptr)
 @ cdecl _mbtowc_l(ptr str long ptr)
 @ cdecl _memccpy(ptr ptr long long)
 @ cdecl _memicmp(str str long)
diff --git a/dlls/msvcrt/mbcs.c b/dlls/msvcrt/mbcs.c
index a17b8a88946..08af661f75e 100644
--- a/dlls/msvcrt/mbcs.c
+++ b/dlls/msvcrt/mbcs.c
@@ -2141,17 +2141,16 @@ unsigned char* CDECL _mbsupr(unsigned char* s)
   return ret;
 }
 
-
 /*********************************************************************
- *              _mbsupr_s(MSVCRT.@)
+ *              _mbsupr_s_l(MSVCRT.@)
  */
-int CDECL _mbsupr_s(unsigned char* s, size_t len)
+int CDECL _mbsupr_s_l(unsigned char* s, size_t len, _locale_t locale)
 {
   if (!s && !len)
   {
     return 0;
   }
-  else if (!s || !len)
+  else if (!s || !len || strnlen(s, len) >= len)
   {
     *_errno() = EINVAL;
     return EINVAL;
@@ -2161,7 +2160,7 @@ int CDECL _mbsupr_s(unsigned char* s, size_t len)
     unsigned int c;
     for ( ; *s && len > 0; len--)
     {
-      c = _mbctoupper(_mbsnextc(s));
+      c = _mbctoupper_l(_mbsnextc_l(s, locale), locale);
       /* Note that I assume that the size of the character is unchanged */
       if (c > 255)
       {
@@ -2171,7 +2170,9 @@ int CDECL _mbsupr_s(unsigned char* s, size_t len)
       *s++=c;
     }
   }
-  else for ( ; *s && len > 0; s++, len--) *s = _toupper_l(*s, NULL);
+  else
+    for ( ; *s && len > 0; s++, len--)
+      *s = _toupper_l(*s, locale);
   if (*s)
   {
     *s = '\0';
@@ -2181,6 +2182,14 @@ int CDECL _mbsupr_s(unsigned char* s, size_t len)
   return 0;
 }
 
+/*********************************************************************
+ *              _mbsupr_s(MSVCRT.@)
+ */
+int CDECL _mbsupr_s(unsigned char* s, size_t len)
+{
+  return _mbsupr_s_l(s, len, NULL);
+}
+
 /*********************************************************************
  *              _mbsspn_l (MSVCRT.@)
  */
diff --git a/dlls/msvcrt/tests/string.c b/dlls/msvcrt/tests/string.c
index 49be9ad8271..da002dd43e0 100644
--- a/dlls/msvcrt/tests/string.c
+++ b/dlls/msvcrt/tests/string.c
@@ -2860,6 +2860,13 @@ static void test__mbsupr_s(void)
     ok(ret == EINVAL, "Expected _mbsupr_s to return EINVAL, got %d\n", ret);
     ok(errno == EINVAL, "Expected errno to be EINVAL, got %d\n", errno);
 
+    // If string length is less than declared buffer length,
+    memcpy(buffer, "ABCDEFGH", sizeof("ABCDEFGH"));
+    errno = EBADF;
+    ret = p_mbsupr_s(buffer, 2);
+    ok(ret == EINVAL, "Expected p_mbsupr_s to return EINVAL, got %d\n", ret);
+    ok(errno == EINVAL, "Expected errno to be EINVAL, got %d\n", errno);
+
     memcpy(buffer, "abcdefgh", sizeof("abcdefgh"));
     errno = EBADF;
     ret = p_mbsupr_s(buffer, sizeof("abcdefgh"));
diff --git a/dlls/ucrtbase/ucrtbase.spec b/dlls/ucrtbase/ucrtbase.spec
index 9d22ff00f30..3e3fd8d6965 100644
--- a/dlls/ucrtbase/ucrtbase.spec
+++ b/dlls/ucrtbase/ucrtbase.spec
@@ -717,7 +717,7 @@
 @ cdecl _mbsupr(str)
 @ stub _mbsupr_l
 @ cdecl _mbsupr_s(str long)
-@ stub _mbsupr_s_l
+@ cdecl _mbsupr_s_l(str long ptr)
 @ cdecl _mbtowc_l(ptr str long ptr)
 @ cdecl _memccpy(ptr ptr long long)
 @ cdecl _memicmp(str str long)
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/1090

[PATCH v5 4/4] msvcrt: Add _mbsupr_s_l partial implementation.

[Marvin]

Hi,

It looks like your patch introduced the new failures shown below.
Please investigate and fix them before resubmitting your patch.
If they are not new, fixing them anyway would help a lot. Otherwise
please ask for the known failures list to be updated.

The tests also ran into some preexisting test failures. If you know how
to fix them that would be helpful. See the TestBot job for the details:

The full results can be found at:
https://testbot.winehq.org/JobDetails.pl?Key=125129

Your paranoid android.


=== debian11 (32 bit report) ===

ddraw:
ddraw7.c:15663: Test failed: Expected unsynchronised map for flags 0x1000.
ddraw7.c:15663: Test failed: Expected unsynchronised map for flags 0x3000.

=== debian11 (build log) ===

Use of uninitialized value $Flaky in addition (+) at /home/testbot/lib/WineTestBot/LogUtils.pm line 720, <$LogFile> line 24739.
Use of uninitialized value $Flaky in addition (+) at /home/testbot/lib/WineTestBot/LogUtils.pm line 720, <$LogFile> line 24739.
Use of uninitialized value $Flaky in addition (+) at /home/testbot/lib/WineTestBot/LogUtils.pm line 720, <$LogFile> line 24739.

[PATCH v5 3/4] msvcrt: Add _mbslwr_s_l partial implementation.

[Bartosz Kosiorek]

From: Bartosz Kosiorek <gang65(a)poczta.onet.pl>

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=45273
---
 dlls/msvcr100/msvcr100.spec |  2 +-
 dlls/msvcr110/msvcr110.spec |  2 +-
 dlls/msvcr120/msvcr120.spec |  2 +-
 dlls/msvcr80/msvcr80.spec   |  2 +-
 dlls/msvcr90/msvcr90.spec   |  2 +-
 dlls/msvcrt/mbcs.c          | 20 ++++++++++++++------
 dlls/msvcrt/tests/string.c  | 21 ++++++++++++++-------
 dlls/ucrtbase/ucrtbase.spec |  2 +-
 8 files changed, 34 insertions(+), 19 deletions(-)

diff --git a/dlls/msvcr100/msvcr100.spec b/dlls/msvcr100/msvcr100.spec
index b3fd1af1ecb..90accd39722 100644
--- a/dlls/msvcr100/msvcr100.spec
+++ b/dlls/msvcr100/msvcr100.spec
@@ -1122,7 +1122,7 @@
 @ cdecl _mbslwr(str)
 @ stub _mbslwr_l
 @ cdecl _mbslwr_s(str long)
-@ stub _mbslwr_s_l
+@ cdecl _mbslwr_s_l(str long ptr)
 @ cdecl _mbsnbcat(str str long)
 @ stub _mbsnbcat_l
 @ cdecl _mbsnbcat_s(str long ptr long)
diff --git a/dlls/msvcr110/msvcr110.spec b/dlls/msvcr110/msvcr110.spec
index 28e5e047090..5ca3156ab0b 100644
--- a/dlls/msvcr110/msvcr110.spec
+++ b/dlls/msvcr110/msvcr110.spec
@@ -1479,7 +1479,7 @@
 @ cdecl _mbslwr(str)
 @ stub _mbslwr_l
 @ cdecl _mbslwr_s(str long)
-@ stub _mbslwr_s_l
+@ cdecl _mbslwr_s_l(str long ptr)
 @ cdecl _mbsnbcat(str str long)
 @ stub _mbsnbcat_l
 @ cdecl _mbsnbcat_s(str long ptr long)
diff --git a/dlls/msvcr120/msvcr120.spec b/dlls/msvcr120/msvcr120.spec
index ae4874a7116..a514febaa21 100644
--- a/dlls/msvcr120/msvcr120.spec
+++ b/dlls/msvcr120/msvcr120.spec
@@ -1490,7 +1490,7 @@
 @ cdecl _mbslwr(str)
 @ stub _mbslwr_l
 @ cdecl _mbslwr_s(str long)
-@ stub _mbslwr_s_l
+@ cdecl _mbslwr_s_l(str long ptr)
 @ cdecl _mbsnbcat(str str long)
 @ stub _mbsnbcat_l
 @ cdecl _mbsnbcat_s(str long ptr long)
diff --git a/dlls/msvcr80/msvcr80.spec b/dlls/msvcr80/msvcr80.spec
index 7b484d8be26..9c2498781f0 100644
--- a/dlls/msvcr80/msvcr80.spec
+++ b/dlls/msvcr80/msvcr80.spec
@@ -794,7 +794,7 @@
 @ cdecl _mbslwr(str)
 @ stub _mbslwr_l
 @ cdecl _mbslwr_s(str long)
-@ stub _mbslwr_s_l
+@ cdecl _mbslwr_s_l(str long ptr)
 @ cdecl _mbsnbcat(str str long)
 @ stub _mbsnbcat_l
 @ cdecl _mbsnbcat_s(str long ptr long)
diff --git a/dlls/msvcr90/msvcr90.spec b/dlls/msvcr90/msvcr90.spec
index ab1ef139f9a..ae1add4cb5f 100644
--- a/dlls/msvcr90/msvcr90.spec
+++ b/dlls/msvcr90/msvcr90.spec
@@ -772,7 +772,7 @@
 @ cdecl _mbslwr(str)
 @ stub _mbslwr_l
 @ cdecl _mbslwr_s(str long)
-@ stub _mbslwr_s_l
+@ cdecl _mbslwr_s_l(str long ptr)
 @ cdecl _mbsnbcat(str str long)
 @ stub _mbsnbcat_l
 @ cdecl _mbsnbcat_s(str long ptr long)
diff --git a/dlls/msvcrt/mbcs.c b/dlls/msvcrt/mbcs.c
index 7073fee5bfd..a17b8a88946 100644
--- a/dlls/msvcrt/mbcs.c
+++ b/dlls/msvcrt/mbcs.c
@@ -2065,17 +2065,16 @@ unsigned char* CDECL _mbslwr(unsigned char* s)
   return ret;
 }
 
-
 /*********************************************************************
- *              _mbslwr_s(MSVCRT.@)
+ *              _mbslwr_s_l(MSVCRT.@)
  */
-int CDECL _mbslwr_s(unsigned char* s, size_t len)
+int CDECL _mbslwr_s_l(unsigned char* s, size_t len, _locale_t locale)
 {
   if (!s && !len)
   {
     return 0;
   }
-  else if (!s || !len)
+  else if (!s || !len || strnlen(s, len) >= len)
   {
     *_errno() = EINVAL;
     return EINVAL;
@@ -2085,7 +2084,7 @@ int CDECL _mbslwr_s(unsigned char* s, size_t len)
     unsigned int c;
     for ( ; *s && len > 0; len--)
     {
-      c = _mbctolower(_mbsnextc(s));
+      c = _mbctolower_l(_mbsnextc_l(s, locale), locale);
       /* Note that I assume that the size of the character is unchanged */
       if (c > 255)
       {
@@ -2095,7 +2094,9 @@ int CDECL _mbslwr_s(unsigned char* s, size_t len)
       *s++=c;
     }
   }
-  else for ( ; *s && len > 0; s++, len--) *s = _tolower_l(*s, NULL);
+  else
+    for ( ; *s && len > 0; s++, len--)
+      *s = _tolower_l(*s, locale);
   if (*s)
   {
     *s = '\0';
@@ -2105,6 +2106,13 @@ int CDECL _mbslwr_s(unsigned char* s, size_t len)
   return 0;
 }
 
+/*********************************************************************
+ *              _mbslwr_s(MSVCRT.@)
+ */
+int CDECL _mbslwr_s(unsigned char* str, size_t len)
+{
+  return _mbslwr_s_l(str, len, NULL);
+}
 
 /*********************************************************************
  *              _mbsupr(MSVCRT.@)
diff --git a/dlls/msvcrt/tests/string.c b/dlls/msvcrt/tests/string.c
index 4e525193ced..49be9ad8271 100644
--- a/dlls/msvcrt/tests/string.c
+++ b/dlls/msvcrt/tests/string.c
@@ -133,13 +133,13 @@ static void test_swab( void ) {
     char expected1[] = "ABCDEFGHIJKLMNOPQRSTUVWXYZ@#";
     char expected2[] = "ABCDEFGHIJKLMNOPQRSTUVWX$";
     char expected3[] = "$";
-    
+
     char from[30];
     char to[30];
-    
+
     int testsize;
-    
-    /* Test 1 - normal even case */                               
+
+    /* Test 1 - normal even case */
     memset(to,'$', sizeof(to));
     memset(from,'@', sizeof(from));
     testsize = 26;
@@ -147,7 +147,7 @@ static void test_swab( void ) {
     _swab( from, to, testsize );
     ok(memcmp(to,expected1,testsize) == 0, "Testing even size %d returned '%*.*s'\n", testsize, testsize, testsize, to);
 
-    /* Test 2 - uneven case  */                               
+    /* Test 2 - uneven case  */
     memset(to,'$', sizeof(to));
     memset(from,'@', sizeof(from));
     testsize = 25;
@@ -155,7 +155,7 @@ static void test_swab( void ) {
     _swab( from, to, testsize );
     ok(memcmp(to,expected2,testsize) == 0, "Testing odd size %d returned '%*.*s'\n", testsize, testsize, testsize, to);
 
-    /* Test 3 - from = to */                               
+    /* Test 3 - from = to */
     memset(to,'$', sizeof(to));
     memset(from,'@', sizeof(from));
     testsize = 26;
@@ -163,7 +163,7 @@ static void test_swab( void ) {
     _swab( to, to, testsize );
     ok(memcmp(to,expected1,testsize) == 0, "Testing overlapped size %d returned '%*.*s'\n", testsize, testsize, testsize, to);
 
-    /* Test 4 - 1 bytes */                               
+    /* Test 4 - 1 bytes */
     memset(to,'$', sizeof(to));
     memset(from,'@', sizeof(from));
     testsize = 1;
@@ -2917,6 +2917,13 @@ static void test__mbslwr_s(void)
     ok(ret == EINVAL, "Expected _mbslwr_s to return EINVAL, got %d\n", ret);
     ok(errno == EINVAL, "Expected errno to be EINVAL, got %d\n", errno);
 
+    // If string length is less than declared buffer length,
+    memcpy(buffer, "ABCDEFGH", sizeof("ABCDEFGH"));
+    errno = EBADF;
+    ret = p_mbslwr_s(buffer, 2);
+    ok(ret == EINVAL, "Expected _mbslwr_s to return EINVAL, got %d\n", ret);
+    ok(errno == EINVAL, "Expected errno to be EINVAL, got %d\n", errno);
+
     memcpy(buffer, "ABCDEFGH", sizeof("ABCDEFGH"));
     errno = EBADF;
     ret = p_mbslwr_s(buffer, sizeof("ABCDEFGH"));
diff --git a/dlls/ucrtbase/ucrtbase.spec b/dlls/ucrtbase/ucrtbase.spec
index c803799f4cd..9d22ff00f30 100644
--- a/dlls/ucrtbase/ucrtbase.spec
+++ b/dlls/ucrtbase/ucrtbase.spec
@@ -637,7 +637,7 @@
 @ cdecl _mbslwr(str)
 @ stub _mbslwr_l
 @ cdecl _mbslwr_s(str long)
-@ stub _mbslwr_s_l
+@ cdecl _mbslwr_s_l(str long ptr)
 @ cdecl _mbsnbcat(str str long)
 @ stub _mbsnbcat_l
 @ cdecl _mbsnbcat_s(str long ptr long)
-- 
GitLab


https://gitlab.winehq.org/wine/wine/-/merge_requests/1090