[PATCH 0/3] MR9900: d3d8/tests: ATI2 DS surface creation attempt crashes nvidia.

[Stefan Dösinger]

It doesn't return an error (as it should), it just crashes somewhere deep
in the driver dll.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/9900

[PATCH 1/3] d3d8/tests: ATI2 DS surface creation attempt crashes nvidia.

[Stefan Dösinger]

From: Stefan Dösinger <[e-mail]>

It doesn't return an error (as it should), it just crashes somewhere deep
in the driver dll.
---
 dlls/d3d8/tests/device.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/dlls/d3d8/tests/device.c b/dlls/d3d8/tests/device.c
index 7059e82b128..51a86ba5488 100644
--- a/dlls/d3d8/tests/device.c
+++ b/dlls/d3d8/tests/device.c
@@ -9973,6 +9973,15 @@ static void test_resource_access(void)
                     break;
 
                 case SURFACE_DS:
+                    if (tests[j].format == FORMAT_ATI2 && broken(1))
+                    {
+                        /* The Nvidia Windows driver crashes when attempting to create a ATI2N
+                         * depth stencil surface.
+                         *
+                         * Interestingly this crash does not happen in the d3d9 version of this
+                         * test. */
+                        continue;
+                    }
                     hr = IDirect3DDevice8_CreateDepthStencilSurface(device,
                             16, 16, format, D3DMULTISAMPLE_NONE, &surface);
                     todo_wine_if(tests[j].format == FORMAT_ATI2)
-- 
GitLab


https://gitlab.winehq.org/wine/wine/-/merge_requests/9900

[PATCH 2/3] d3d8/tests: Clarify a skip message.

[Stefan Dösinger]

From: Stefan Dösinger <[e-mail]>

It confused me when debugging the crash because I am sure the previous test
did show that ATI2 textures are supported.
---
 dlls/d3d8/tests/device.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/d3d8/tests/device.c b/dlls/d3d8/tests/device.c
index 51a86ba5488..e777ac0aba3 100644
--- a/dlls/d3d8/tests/device.c
+++ b/dlls/d3d8/tests/device.c
@@ -10096,7 +10096,7 @@ static void test_resource_access(void)
         {
             if (!skip_ati2n_once)
             {
-                skip("ATI2N texture not supported.\n");
+                skip("ATI2N volume texture not supported.\n");
                 skip_ati2n_once = TRUE;
             }
             continue;
-- 
GitLab


https://gitlab.winehq.org/wine/wine/-/merge_requests/9900

[PATCH 3/3] d3d9/tests: Clarify a skip message.

[Stefan Dösinger]

From: Stefan Dösinger <[e-mail]>

---
 dlls/d3d9/tests/device.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/d3d9/tests/device.c b/dlls/d3d9/tests/device.c
index b782833c37d..fd596de84c6 100644
--- a/dlls/d3d9/tests/device.c
+++ b/dlls/d3d9/tests/device.c
@@ -13988,7 +13988,7 @@ static void test_resource_access(void)
         {
             if (!skip_ati2n_once)
             {
-                skip("ATI2N texture not supported.\n");
+                skip("ATI2N volume texture not supported.\n");
                 skip_ati2n_once = TRUE;
             }
             continue;
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/9900

[PATCH 0/3] MR9900: d3d8/tests: ATI2 DS surface creation attempt crashes nvidia. - approved

[Elizabeth Figura (＠zfigura)]

This merge request was approved by Elizabeth Figura.
-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/9900