[PATCH 0/1] MR11019: Add a stub implementation for DwmpSetColorizationColor(DWORD*,BOOL)

[tobbi (＠tobbi)]

This is just a small stub implementation to help fix the crash described in https://bugs.winehq.org/show_bug.cgi?id=48370

The program still doesn't work, but at least it doesn't crash anymore.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/11019

[PATCH 1/1] Add a stub for DwmpSetColorizationColor(DWORD*,BOOL)

[Tobias Markus]

From: Tobias Markus <[e-mail]>

---
 dlls/dwmapi/dwmapi.spec   | 2 +-
 dlls/dwmapi/dwmapi_main.c | 7 +++++++
 2 files changed, 8 insertions(+), 1 deletion(-)

diff --git a/dlls/dwmapi/dwmapi.spec b/dlls/dwmapi/dwmapi.spec
index e69c3e3e82a..baa0b475427 100644
--- a/dlls/dwmapi/dwmapi.spec
+++ b/dlls/dwmapi/dwmapi.spec
@@ -2,7 +2,7 @@
 101 stub DwmpDxUpdateWindowSharedSurface
 102 stdcall DwmEnableComposition(long)
 103 stub -noname DwmpRestartComposition
-104 stub -noname DwmpSetColorizationColor
+104 stdcall DwmpSetColorizationColor(ptr ptr)
 105 stub -noname DwmpStartOrStopFlip3D
 106 stub -noname DwmpIsCompositionCapable
 107 stub -noname DwmpGetGlobalState
diff --git a/dlls/dwmapi/dwmapi_main.c b/dlls/dwmapi/dwmapi_main.c
index 49e05cd207e..734959ecd17 100644
--- a/dlls/dwmapi/dwmapi_main.c
+++ b/dlls/dwmapi/dwmapi_main.c
@@ -63,6 +63,13 @@ HRESULT WINAPI DwmEnableComposition(UINT uCompositionAction)
     return S_OK;
 }
 
+HRESULT WINAPI DwmpSetColorizationColor(DWORD *pcrColorization, BOOL* pfOpaqueBlend)
+{
+    FIXME("(%p %p) stub\n", pcrColorization, pfOpaqueBlend);
+
+    return S_OK;
+}
+
 /**********************************************************************
  *           DwmExtendFrameIntoClientArea    (DWMAPI.@)
  */
-- 
GitLab

https://gitlab.winehq.org/wine/wine/-/merge_requests/11019

[Elizabeth Figura (＠zfigura)]

I think -noname should remain.

```
+HRESULT WINAPI DwmpSetColorizationColor(DWORD *pcrColorization, BOOL* pfOpaqueBlend)
```

Could we keep the asterisks consistent? And also avoid Hungarian notation in new code?

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/11019#note_141562

[Elizabeth Figura (＠zfigura)]

Oh, also, I believe we require explicit approvals for other people's patches, so you'll either need to change your gitlab username to match the name on the patch, or explicitly approve the patch.

-- 
https://gitlab.winehq.org/wine/wine/-/merge_requests/11019#note_141563